If you add a domain to the whitelist and the blocklist the following error occurs, and the UI doesnt reflect this
Mar 3 22:42:06 OpenWrt adblock-4.1.5[15830]: blocklist with overall 191167 blocked domains loaded successfully (Linksys WRT1900ACS, OpenWrt 22.03.0 r19685-512e76967f)
Mar 3 22:42:13 OpenWrt named[15953]: dns_master_load: /var/lib/bind/adb_list.overall:329364: domain.tld.rpz: multiple RRs of singleton type
Mar 3 22:42:13 OpenWrt named[15953]: zone rpz/IN: loading from master file /var/lib/bind/adb_list.overall failed: multiple RRs of singleton type
Mar 3 22:42:13 OpenWrt named[15953]: zone rpz/IN: not loaded due to errors.
Hey @dibdot! I noticed a while back that one of the lists I maintain is included as an option in the AdBlock package, which is awesome. I'm not a big forum guy, but I figured it would probably be a good idea to mention that I produce TLD-compressed variants of my lists. It appears that you're using my plain domains blacklist, so here's the URL for the compressed version: https://raw.githubusercontent.com/bongochong/CombinedPrivacyBlockLists/master/NoFormatting/cpbl-ctld.txt
Lists of mine which are optimized in such a fashion are run through an additional set of exclusion patterns to ensure that my primary whitelist is properly applied to them, so switching over to that URL in the adblock.sources file would be a win-win (more efficient, and less manual whitelisting work for users).
Many thanks for maintaining this vital software. Your adblock package - and the simple-adblock package (maintained by @stangri) - have been immensely valuable to me since I first started running OpenWrt.
OpenWrt 22.03: DNS hijacking firewall rules added by adblock only apply to IPv4 DNS. DNS requests via IPv6 pass through normally.
E.g. dig cloudflare.com @2001:4860:4860::8844 goes directly to Google's IPv6 DNS server.
Solution:
Add rules with explicit ipv6 family specification:
config redirect 'adblock_lan53_ipv6' <------ this one
option name 'Adblock DNS (IPv6, lan, 53)' <------ this one
option src 'lan'
option proto 'tcp udp'
option src_dport '53'
option dest_port '53'
option family 'ipv6' <------ this one
option target 'DNAT'
Hi there, I've been running adblock successfully for years, but have recently been unable to load the DNS Report view. Luci shows " SyntaxError: JSON.parse: end of data when property name was expected at line 423 column 1 of the JSON data". This occurs even if I deselect all blocklist sources, save, and refresh. Ad blocking itself seems to run fine. Any suggestions for diagnosing or fixing this?
Adblock works by blocking whole domains, so your list is blocking all of s3.amazonaws.com. Everything after that in the URL is of no consequence, as it's just the document location on the domain host.