Yes, at least the /etc/config/network file looks right, assuming that your ISP uses VLAN 911 and PPPoE.
This is confusing to me... it's not clear to me what your ISP really requires, and this is information that you need to get from your ISP directly.
What happens if you plug your computer directly into the DSL modem (so direct connection, no switch between them)? Does your computer get an IP address and can it reach the internet? What are the first two octets of your comptuer's IP address (in bold aaa.bbb.ccc.ddd)?
Sorry for the late reply. I only have a 30 min window to do my dev work! There is work, so I am not able to bring Internet down, then Uni stuff, then TV till midnight! So my work is not a priority!
Anyway, I just tried, I am not getting the IP address. I get 169.254
I think I am getting closer to give up now. I have another router I can plug in to secure the traffic and get rid off the VF router.
Yes, most likely it needs to be tagged as has been discussed a few times here. On your switch, change the VLAN 911 port-membership such that it is tagged on port 8.
And no... no tips and tricks per-se because we don't know your specific use case/needs/requirements.
If you have certain things in mind (like guest networks, traffic shaping, VPNs, etc.), we can help you with those, but be sure to form a clear understanding of your goals so that you can communicate them as you ask how to do certain things.
That said, those would all be worthy of a new thread, so please open a new one if/when you need that assistance, and in the meantime you can mark this one as solved.