Dear Community,
I own two ZyXEL XGS1250-12 switches currently running the manufacturers firmware. I bought the switches because they offer a wider range of different port speeds on the 3 multi-gigabit RJ45 ports than similar models whilst offering a 10G SFP+ port for a fiber uplink.
Running OpenWRT on them worked just fine on them the last time i tested. Because of the lack of support for the SFP+ port, i had to switch back to the ZyXEL provided firmware.
The TOH entry for the device still lists the SFP+ port as an unsupported function (https://openwrt.org/toh/zyxel/xgs1250-12). What is needed on the development side to get the ports in a usable state in OpenWRT main branch and possibly into the next stable release?
Kind regards,
David
1 Like
There's a relevant PR: https://github.com/openwrt/openwrt/pull/14281
The changes have been tested, so they should be good, but my request to clean things up a bit didn't get any response...
1 Like
@svanheule Thank you very much for pointing out that PR to me. I will try and test the (rebased) changes on one of the two switches this weekend.
It would be nice however to get the changes into main. What is the stance of the community on pushing cleanup commits into other contributors (potentially abandoned) PRs?
The patches are "out there". If you feel like you can tidy things up a bit, you can just take the patches and submit your own pull request with the modifications.
In case you want to maintain a record of "who did what" (especially if the changes are minor), you can append a description of your changes and a Signed-off-by tag to the commit message. See commit 2e715fb4fc for an example.
1 Like
Thanks. I might do some cleanup work if i find the time, but i really would like to avoid any conflict with the original contributor of the PR. I'll contact him, maybe he just needs some more time to work on the requested changes to his submission.
EDIT: I contacted Tobias via email, i'll wait for his answer first.
4 Likes