Support for RTL838x based managed switches

[svanheule]

I made the mistake of looking more closely at the frame tag and multicast code, and ended up documenting some of the magic values in the code for RTL838x. Of course the values are slightly inconsistent with what would naively be expected by looking at the registers...

For example, RTL838X_RMA_CTRL_0 is set to 0x1FFFFFF for IFF_ALLMULTI. This means that certain types of multicast addresses will be flooded to all ports, except for those with a reserved multicast address (RMA) matching 01-80-C2-00-00-2x. The latter will be dropped instead. Consistent behaviour for all RMA types would be achieved by setting the value to 0x3FFFFFF, but of course I can't be sure if this was intentional, or just the result of improper mask calculation.

[olliver]

@piaddic7ed

Another issue is the 2.5G ports failing randomly.

I've just pushed my latest status; and 2.5 is working fine it seems; also, I've tested with my 1m 10G DAC cable, and both ports are recognized and a 'packet storm' ensures (which could be argued is good :p)

[piaddic7ed]

When inserting my 1Gbit HP SFP module I still get en error, but the message has slightly changed (the 2nd line is new).

[  139.153139] sfp sfp-p11: module AVAGO            ABCU-5712RZ-HP1  rev      sn 2Y1526MYAG       dc 150625  
[  139.244575] rtl83xx-switch switch@1b000000 lan11: validation with support 0000000,00000000,00000000 failed: -22
[  139.256004] sfp sfp-p11: sfp_add_phy failed: -22

The other issues remain unchanged. 2.5Gbit/s still failing 90% of the time (I'm also using a Realtek 2.5 to USB adapter). 2.5Gbit/s connections are fine with master builds. VLANs, same as before, no routing possible. I've included dnsmasq and odhcpd into my test image just for fun. Turns out that only one of the local interfaces is actually responding to dhcp requests. It's as if the CPU is limited to one interface at a time. Yet, removing ports from the bridge does work as before.

[olliver]

@piaddic7ed

So, I've played with brctl and split off the switch. I have 2 USB ethernet adapters (1G/100M) where I connect to lan1, my 1G adapter, and run a dhcp server on my desktop. I think daisychain stuff together, and (try to) run a dhcp client on my second USB adapter. So in theory, dhcp server on usb0 -> switch -> usb1 should give me a dhcp result, sadly, due to DSA I can't get that to work (with the default setup from openwrt. Isolation? Idk, but the switch is not operating as a 'normal unmanaged switch' in that sense.

[12419.256175] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[12419.263598] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[12424.376254] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64901.617040] rtl83xx_fib4_del: no such gateway: 0.0.0.0
[64901.622772] rtl83xx_fib4_del: no such gateway: 0.0.0.0
[64901.630592] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64901.638082] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64901.673273] rtl83xx_fib4_del: no such gateway: 0.0.0.0
[64901.679006] rtl83xx_fib4_del: no such gateway: 0.0.0.0
[64901.822696] switch: port 1(lan1) entered disabled state
[64901.854699] device lan1 left promiscuous mode
[64901.859730] switch: port 1(lan1) entered disabled state
[64901.890464] rtl930x_switch_irq link faults: 0fffff00
[64901.895997] rtl930x_switch_irq RX symbol errors: 00000004
[64901.902082] rtl83xx-switch switch@1b000000 lan1: Link is Down
[64901.927097] device lan10 left promiscuous mode
[64901.932229] switch: port 10(lan10) entered disabled state
[64901.964256] device lan11 left promiscuous mode
[64901.969383] switch: port 11(lan11) entered disabled state
[64901.996589] device lan12 left promiscuous mode
[64902.001717] switch: port 12(lan12) entered disabled state
[64902.021018] device lan2 left promiscuous mode
[64902.026111] switch: port 2(lan2) entered disabled state
[64902.061380] device lan3 left promiscuous mode
[64902.066497] switch: port 3(lan3) entered disabled state
[64902.080286] device lan4 left promiscuous mode
[64902.085387] switch: port 4(lan4) entered disabled state
[64902.097924] device lan5 left promiscuous mode
[64902.102971] switch: port 5(lan5) entered disabled state
[64902.115505] device lan6 left promiscuous mode
[64902.120533] switch: port 6(lan6) entered disabled state
[64902.133483] device lan7 left promiscuous mode
[64902.138534] switch: port 7(lan7) entered disabled state
[64902.151300] device lan8 left promiscuous mode
[64902.156402] switch: port 8(lan8) entered disabled state
[64902.169291] device lan9 left promiscuous mode
[64902.174400] switch: port 9(lan9) entered disabled state
[64902.182706] in rtl838x_eth_stop
[64902.186843] rtl838x-eth 1b00a300.ethernet eth0: Link is Down
[64902.693009] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64902.700489] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64902.707946] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64902.715393] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64903.730528] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64903.761830] Using MAC 000000e04c000000
[64903.779473] RESETTING 9300, CPU_PORT 28
[64903.984106] rtl838x-eth 1b00a300.ethernet eth0: configuring for fixed/internal link mode
[64903.993092] In rtl838x_mac_config, mode 1
[64903.997684] device eth0 left promiscuous mode
[64904.002858] In rtl838x_mac_config, mode 1
[64904.007412] rtl838x-eth 1b00a300.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
[64904.036964] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
[64904.044069] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64904.051498] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64904.102837] rtl83xx-switch switch@1b000000 lan1: configuring for phy/xgmii link mode
[64904.111546] rtl93xx_phylink_mac_config port 0, mode 0, phy-mode: xgmii, speed 1000, link 0
[64904.120784] rtl93xx_phylink_mac_config SDS is 2
[64904.127226] 8021q: adding VLAN 0 to HW filter on device lan1
[64904.143815] switch: port 1(lan1) entered blocking state
[64904.149640] switch: port 1(lan1) entered disabled state
[64904.156811] device lan1 entered promiscuous mode
[64904.161956] device eth0 entered promiscuous mode
[64904.223490] rtl83xx-switch switch@1b000000 lan2: configuring for phy/xgmii link mode
[64904.232120] rtl93xx_phylink_mac_config port 1, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.241186] rtl93xx_phylink_mac_config SDS is -1
[64904.247407] 8021q: adding VLAN 0 to HW filter on device lan2
[64904.340754] switch: port 2(lan2) entered blocking state
[64904.346646] switch: port 2(lan2) entered disabled state
[64904.378594] device lan2 entered promiscuous mode
[64904.404013] rtl83xx-switch switch@1b000000 lan3: configuring for phy/xgmii link mode
[64904.412640] rtl93xx_phylink_mac_config port 2, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.421707] rtl93xx_phylink_mac_config SDS is -1
[64904.428116] 8021q: adding VLAN 0 to HW filter on device lan3
[64904.444736] switch: port 3(lan3) entered blocking state
[64904.450561] switch: port 3(lan3) entered disabled state
[64904.457500] device lan3 entered promiscuous mode
[64904.473366] rtl83xx-switch switch@1b000000 lan4: configuring for phy/xgmii link mode
[64904.482032] rtl93xx_phylink_mac_config port 3, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.491087] rtl93xx_phylink_mac_config SDS is -1
[64904.497871] 8021q: adding VLAN 0 to HW filter on device lan4
[64904.515051] switch: port 4(lan4) entered blocking state
[64904.520959] switch: port 4(lan4) entered disabled state
[64904.528073] device lan4 entered promiscuous mode
[64904.544232] rtl83xx-switch switch@1b000000 lan5: configuring for phy/xgmii link mode
[64904.552863] rtl93xx_phylink_mac_config port 4, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.561931] rtl93xx_phylink_mac_config SDS is -1
[64904.568366] 8021q: adding VLAN 0 to HW filter on device lan5
[64904.584978] switch: port 5(lan5) entered blocking state
[64904.590803] switch: port 5(lan5) entered disabled state
[64904.597750] device lan5 entered promiscuous mode
[64904.613640] rtl83xx-switch switch@1b000000 lan6: configuring for phy/xgmii link mode
[64904.622273] rtl93xx_phylink_mac_config port 5, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.631341] rtl93xx_phylink_mac_config SDS is -1
[64904.638104] 8021q: adding VLAN 0 to HW filter on device lan6
[64904.654723] switch: port 6(lan6) entered blocking state
[64904.660545] switch: port 6(lan6) entered disabled state
[64904.667505] device lan6 entered promiscuous mode
[64904.683393] rtl83xx-switch switch@1b000000 lan7: configuring for phy/xgmii link mode
[64904.692024] rtl93xx_phylink_mac_config port 6, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.701087] rtl93xx_phylink_mac_config SDS is -1
[64904.707841] 8021q: adding VLAN 0 to HW filter on device lan7
[64904.724454] switch: port 7(lan7) entered blocking state
[64904.730271] switch: port 7(lan7) entered disabled state
[64904.736554] device lan7 entered promiscuous mode
[64904.752365] rtl83xx-switch switch@1b000000 lan8: configuring for phy/xgmii link mode
[64904.761061] rtl93xx_phylink_mac_config port 7, mode 0, phy-mode: xgmii, speed -1, link 0
[64904.770116] rtl93xx_phylink_mac_config SDS is -1
[64904.776814] 8021q: adding VLAN 0 to HW filter on device lan8
[64904.793507] switch: port 8(lan8) entered blocking state
[64904.799330] switch: port 8(lan8) entered disabled state
[64904.805608] device lan8 entered promiscuous mode
[64904.820856] rtl83xx-switch switch@1b000000 lan9: configuring for phy/hsgmii link mode
[64904.829646] rtl93xx_phylink_mac_config port 24, mode 0, phy-mode: hsgmii, speed -1, link 0
[64904.838883] rtl93xx_phylink_mac_config SDS is 6
[64904.844953] rtl93xx_phylink_mac_config CURRENT FORCED MODE 2
[64904.851396] 8021q: adding VLAN 0 to HW filter on device lan9
[64904.858691] In rtl8226_advertise_aneg
[64904.873693] switch: port 9(lan9) entered blocking state
[64904.879518] switch: port 9(lan9) entered disabled state
[64904.885804] device lan9 entered promiscuous mode
[64904.900379] rtl83xx-switch switch@1b000000 lan10: configuring for phy/hsgmii link mode
[64904.909263] rtl93xx_phylink_mac_config port 25, mode 0, phy-mode: hsgmii, speed -1, link 0
[64904.918501] rtl93xx_phylink_mac_config SDS is 7
[64904.924571] rtl93xx_phylink_mac_config CURRENT FORCED MODE 2
[64904.931014] 8021q: adding VLAN 0 to HW filter on device lan10
[64904.938413] In rtl8226_advertise_aneg
[64904.953465] switch: port 10(lan10) entered blocking state
[64904.959478] switch: port 10(lan10) entered disabled state
[64904.965973] device lan10 entered promiscuous mode
[64904.980700] rtl83xx-switch switch@1b000000 lan11: configuring for inband/1000base-x link mode
[64904.990278] rtl93xx_phylink_mac_config port 26, mode 2, phy-mode: 1000base-x, speed -1, link 0
[64904.999903] rtl93xx_phylink_mac_config SDS is 8
[64905.010968] rtl9300_configure_serdes CMU BAND is 16
[64905.016425] rtl9300_sds_rst SDS 8 to mode 0x1f
[64905.021359] rtl9300_sds_set set serdes 8 to mode 0x1f
[64905.037001] rtl9300_sds_set set serdes 8 to mode 0x1f
[64905.052630] rtl9300_sds_rst: 194:007d07df 198:000007df 2a0:007df7df 2a4:000007df
[64905.080871] rtl9300_configure_serdes: Configuring RTL9300 SERDES 8
[64905.089778] rtl9300_serdes_mac_link_config: registers before 00000000 00001403
[64905.101838] rtl9300_serdes_mac_link_config: registers after 00000000 00001403
[64905.109816] rtl9300_force_sds_mode: SDS: 8, PHY mode 0
[64905.115560] rtl9300_force_sds_mode: forcing SDS mode 1f
[64905.127394] rtl9300_force_sds_mode: SDS: 8, PHY mode 21
[64905.133234] rtl9300_force_sds_mode: forcing SDS mode 4
[64905.360624] rtl9300_force_sds_mode toggling LC or Ring for 10gr, round 0
[64905.404075] rtl9300_force_sds_mode end power 0x20 0 30
[64905.409784] rtl9300_force_sds_mode -------------------- serdes 8 forced to 4 DONE
[64905.507083] rtl9300_sds_tx_config SerDes 8, pre-amp enable 1, pre-amp val 1, main-amp 9, post-amp enable 1, post-amp val 1, impedance 8
[64905.532791] 8021q: adding VLAN 0 to HW filter on device lan11
[64905.552998] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64905.560500] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64905.573919] switch: port 11(lan11) entered blocking state
[64905.579934] switch: port 11(lan11) entered disabled state
[64905.586428] device lan11 entered promiscuous mode
[64905.602649] rtl83xx-switch switch@1b000000 lan12: configuring for inband/1000base-x link mode
[64905.612216] rtl93xx_phylink_mac_config port 27, mode 2, phy-mode: 1000base-x, speed -1, link 0
[64905.621840] rtl93xx_phylink_mac_config SDS is 9
[64905.632897] rtl9300_configure_serdes CMU BAND is 16
[64905.638372] rtl9300_sds_rst SDS 9 to mode 0x1f
[64905.643363] rtl9300_sds_set set serdes 9 to mode 0x1f
[64905.658989] rtl9300_sds_set set serdes 9 to mode 0x1f
[64905.674641] rtl9300_sds_rst: 194:007d07df 198:000007df 2a0:007df7df 2a4:000007df
[64905.702850] rtl9300_configure_serdes: Configuring RTL9300 SERDES 9
[64905.711746] rtl9300_serdes_mac_link_config: registers before 00000000 00001403
[64905.723839] rtl9300_serdes_mac_link_config: registers after 00000000 00001403
[64905.731774] rtl9300_force_sds_mode: SDS: 9, PHY mode 0
[64905.737517] rtl9300_force_sds_mode: forcing SDS mode 1f
[64905.749350] rtl9300_force_sds_mode: SDS: 9, PHY mode 21
[64905.755212] rtl9300_force_sds_mode: forcing SDS mode 4
[64905.982603] rtl9300_force_sds_mode toggling LC or Ring for 10gr, round 0
[64906.026053] rtl9300_force_sds_mode end power 0x20 0 30
[64906.031760] rtl9300_force_sds_mode -------------------- serdes 9 forced to 4 DONE
[64906.129060] rtl9300_sds_tx_config SerDes 9, pre-amp enable 1, pre-amp val 1, main-amp 9, post-amp enable 1, post-amp val 1, impedance 8
[64906.154778] 8021q: adding VLAN 0 to HW filter on device lan12
[64906.183600] switch: port 12(lan12) entered blocking state
[64906.189615] switch: port 12(lan12) entered disabled state
[64906.196105] device lan12 entered promiscuous mode
[64906.208606] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64907.650817] rtl93xx_phylink_mac_config port 0, mode 0, phy-mode: xgmii, speed 1000, link 1
[64907.660054] rtl93xx_phylink_mac_config SDS is 2
[64907.665165] rtl83xx-switch switch@1b000000 lan1: Link is Up - 1Gbps/Full - flow control rx/tx
[64907.675231] rtl930x_switch_irq link faults: 0fffff00
[64907.680746] rtl930x_switch_irq RX symbol errors: 00000004
[64907.687311] switch: port 1(lan1) entered blocking state
[64907.693196] switch: port 1(lan1) entered forwarding state
[64907.701529] rtl93xx_phylink_mac_config port 0, mode 0, phy-mode: xgmii, speed 1000, link 1
[64907.710818] rtl93xx_phylink_mac_config SDS is 2
[64907.716654] IPv6: ADDRCONF(NETDEV_CHANGE): switch: link becomes ready
[64907.725865] IPv6: ADDRCONF(NETDEV_CHANGE): switch.1: link becomes ready
[64908.049407] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64908.059801] Not offloading default route for now
[64908.065988] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64909.873227] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[64909.880652] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[65014.089860] device lan8 left promiscuous mode
[65014.094893] switch: port 8(lan8) entered disabled state
[65024.801084] device lan7 left promiscuous mode
[65024.806123] switch: port 7(lan7) entered disabled state
[65029.420843] device lan10 left promiscuous mode
[65029.426048] switch: port 10(lan10) entered disabled state
[65032.468475] device lan11 left promiscuous mode
[65032.473673] switch: port 11(lan11) entered disabled state
[65092.019287] switch2: port 1(lan11) entered blocking state
[65092.025302] switch2: port 1(lan11) entered disabled state
[65092.032456] device lan11 entered promiscuous mode
[65146.006371] switch3: port 1(lan8) entered blocking state
[65146.012287] switch3: port 1(lan8) entered disabled state
[65146.018683] device lan8 entered promiscuous mode
[65158.605315] switch2: port 2(lan10) entered blocking state
[65158.611398] switch2: port 2(lan10) entered disabled state
[65158.617811] device lan10 entered promiscuous mode
[65197.441738] device lan9 left promiscuous mode
[65197.446776] switch: port 9(lan9) entered disabled state
[65205.313282] switch3: port 2(lan9) entered blocking state
[65205.319196] switch3: port 2(lan9) entered disabled state
[65205.326244] device lan9 entered promiscuous mode
[65217.464100] sfp sfp-p12: module MikroTik         XS+DA0001        rev 1.0  sn S200902261428    dc 20091800
[65217.474908] rtl83xx-switch switch@1b000000 lan12: switched to inband/10gbase-r link mode
[65217.483912] rtl93xx_phylink_mac_config port 27, mode 2, phy-mode: 10gbase-r, speed -1, link 0
[65217.493445] rtl93xx_phylink_mac_config SDS is 9
[65217.504504] rtl9300_configure_serdes CMU BAND is 16
[65217.509966] rtl9300_sds_rst SDS 9 to mode 0x1f
[65217.514938] rtl9300_sds_set set serdes 9 to mode 0x1f
[65217.530558] rtl9300_sds_set set serdes 9 to mode 0x1f
[65217.546212] rtl9300_sds_rst: 194:007d07df 198:000007df 2a0:007df7df 2a4:000007df
[65217.555472] rtl9300_phy_enable_10g_1g 1gbit phy: 00001140
[65217.562468] rtl9300_phy_enable_10g_1g 1gbit phy enabled: 00001140
[65217.570275] rtl9300_phy_enable_10g_1g 10gbit phy: 00002040
[65217.577411] rtl9300_phy_enable_10g_1g 10gbit phy after: 00002040
[65217.585124] rtl9300_phy_enable_10g_1g set medium: 00000002
[65217.592213] rtl9300_phy_enable_10g_1g set medium after: 00000002
[65217.618902] rtl9300_configure_serdes: Configuring RTL9300 SERDES 9
[65217.627802] rtl9300_serdes_mac_link_config: registers before 00000000 00001403
[65217.639861] rtl9300_serdes_mac_link_config: registers after 00000000 00001403
[65217.647834] rtl9300_force_sds_mode: SDS: 9, PHY mode 0
[65217.653540] rtl9300_force_sds_mode: forcing SDS mode 1f
[65217.665406] rtl9300_force_sds_mode: SDS: 9, PHY mode 25
[65217.671211] rtl9300_force_sds_mode: forcing SDS mode 1a
[65217.898736] rtl9300_force_sds_mode toggling LC or Ring for 10gr, round 0
[65217.934229] rtl930x_switch_irq link faults: 0fffff00
[65217.939748] rtl930x_switch_irq RX symbol errors: 00000004
[65217.945784] rtl930x_switch_irq link faults: 0fffff00
[65217.951298] rtl930x_switch_irq RX symbol errors: 00000004
[65217.971220] rtl930x_switch_irq link faults: 0fffff00
[65217.976733] rtl930x_switch_irq RX symbol errors: 00000004
[65217.995991] rtl930x_switch_irq link faults: 0fffff00
[65218.001512] rtl930x_switch_irq RX symbol errors: 00000004
[65218.043376] rtl9300_force_sds_mode end power 0x20 0 30
[65218.049121] rtl9300_force_sds_mode -------------------- serdes 9 forced to 1a DONE
[65218.146544] rtl9300_sds_tx_config SerDes 9, pre-amp enable 1, pre-amp val 2, main-amp 9, post-amp enable 1, post-amp val 2, impedance 8
[65231.168914] sfp sfp-p11: module MikroTik         XS+DA0001        rev 1.0  sn S200902261428    dc 20091800
[65231.179724] rtl83xx-switch switch@1b000000 lan11: switched to inband/10gbase-r link mode
[65231.188727] rtl93xx_phylink_mac_config port 26, mode 2, phy-mode: 10gbase-r, speed -1, link 0
[65231.198271] rtl93xx_phylink_mac_config SDS is 8
[65231.209341] rtl9300_configure_serdes CMU BAND is 16
[65231.214804] rtl9300_sds_rst SDS 8 to mode 0x1f
[65231.219772] rtl9300_sds_set set serdes 8 to mode 0x1f
[65231.235389] rtl9300_sds_set set serdes 8 to mode 0x1f
[65231.251026] rtl9300_sds_rst: 194:007d07df 198:000007df 2a0:007df7df 2a4:000007df
[65231.260283] rtl9300_phy_enable_10g_1g 1gbit phy: 00001140
[65231.267283] rtl9300_phy_enable_10g_1g 1gbit phy enabled: 00001140
[65231.275089] rtl9300_phy_enable_10g_1g 10gbit phy: 00002040
[65231.282209] rtl9300_phy_enable_10g_1g 10gbit phy after: 00002040
[65231.289920] rtl9300_phy_enable_10g_1g set medium: 00000002
[65231.297011] rtl9300_phy_enable_10g_1g set medium after: 00000002
[65231.323717] rtl9300_configure_serdes: Configuring RTL9300 SERDES 8
[65231.332617] rtl9300_serdes_mac_link_config: registers before 00000000 00001403
[65231.344682] rtl9300_serdes_mac_link_config: registers after 00000000 00001403
[65231.352649] rtl9300_force_sds_mode: SDS: 8, PHY mode 0
[65231.358356] rtl9300_force_sds_mode: forcing SDS mode 1f
[65231.370203] rtl9300_force_sds_mode: SDS: 8, PHY mode 25
[65231.376009] rtl9300_force_sds_mode: forcing SDS mode 1a
[65231.405228] rtl930x_switch_irq link faults: 0fffff00
[65231.410749] rtl930x_switch_irq RX symbol errors: 00000104
[65231.615070] rtl9300_force_sds_mode toggling LC or Ring for 10gr, round 0
[65231.650583] rtl930x_switch_irq link faults: 0fffff00
[65231.656104] rtl930x_switch_irq RX symbol errors: 00000104
[65231.677221] rtl930x_switch_irq link faults: 0fffff00
[65231.682734] rtl930x_switch_irq RX symbol errors: 00000104
[65231.701799] rtl930x_switch_irq link faults: 0fffff00
[65231.707319] rtl930x_switch_irq RX symbol errors: 00000104
[65231.728219] rtl930x_switch_irq link faults: 0fffff00
[65231.733737] rtl930x_switch_irq RX symbol errors: 00000104
[65231.749916] rtl930x_switch_irq link faults: 0fffff00
[65231.755435] rtl930x_switch_irq RX symbol errors: 00000104
[65231.771227] rtl9300_force_sds_mode end power 0x20 0 30
[65231.776941] rtl9300_force_sds_mode -------------------- serdes 8 forced to 1a DONE
[65231.785391] rtl930x_switch_irq link faults: 0fffff00
[65231.785397] rtl930x_switch_irq RX symbol errors: 00000104
[65231.841222] rtl930x_switch_irq link faults: 07ffff00
[65231.846735] rtl930x_switch_irq RX symbol errors: 00000104
[65231.897437] rtl9300_sds_tx_config SerDes 8, pre-amp enable 1, pre-amp val 2, main-amp 9, post-amp enable 1, post-amp val 2, impedance 8
[65231.959260] rtl83xx-switch switch@1b000000 lan12: Link is Up - 10Gbps/Full - flow control off
[65231.968849] switch: port 12(lan12) entered blocking state
[65231.974932] switch: port 12(lan12) entered forwarding state
[65231.983592] rtl83xx-switch switch@1b000000 lan11: Link is Up - 10Gbps/Full - flow control off
[65651.114930] rtl93xx_phylink_mac_config port 25, mode 0, phy-mode: hsgmii, speed 2500, link 1
[65651.124373] rtl93xx_phylink_mac_config SDS is 7
[65651.130454] rtl93xx_phylink_mac_config CURRENT FORCED MODE 2
[65651.136741] rtl9300_rtl8226_mode_set setting serdes 7 to mode hsgmii +++++
[65651.164385] rtl9300_force_sds_mode: SDS: 7, PHY mode 0
[65651.170092] rtl9300_force_sds_mode: forcing SDS mode 1f
[65651.183943] rtl9300_serdes_mac_link_config: registers before 00000000 00001403
[65651.196005] rtl9300_serdes_mac_link_config: registers after 00000000 00001403
[65651.214231] rtl930x_switch_irq link faults: 03ffff00
[65651.219745] rtl930x_switch_irq RX symbol errors: 000001c4
[65651.302468] rtl9300_force_sds_mode: SDS: 7, PHY mode 17
[65651.308271] rtl9300_force_sds_mode: forcing SDS mode 12
[65651.535743] rtl9300_force_sds_mode toggling LC or Ring for 10gr, round 0
[65651.570188] rtl9300_force_sds_mode end power 0x20 0 30
[65651.575934] rtl9300_force_sds_mode -------------------- serdes 7 forced to 12 DONE
[65651.584389] rtl9300_sds_tx_config SerDes 7, pre-amp enable 0, pre-amp val 0, main-amp 9, post-amp enable 1, post-amp val 8, impedance 8
[65651.609952] rtl930x_switch_irq link faults: 03ffff00
[65651.615471] rtl930x_switch_irq RX symbol errors: 000001c4
[65651.621530] rtl83xx-switch switch@1b000000 lan10: Link is Up - 2.5Gbps/Full - flow control off
[65651.632710] rtl93xx_phylink_mac_config port 24, mode 0, phy-mode: hsgmii, speed 2500, link 1
[65651.642178] rtl93xx_phylink_mac_config SDS is 6
[65651.648205] rtl93xx_phylink_mac_config CURRENT FORCED MODE 2
[65651.654529] rtl9300_rtl8226_mode_set setting serdes 6 to mode hsgmii +++++
[65651.682187] rtl9300_force_sds_mode: SDS: 6, PHY mode 0
[65651.687900] rtl9300_force_sds_mode: forcing SDS mode 1f
[65651.701740] rtl9300_serdes_mac_link_config: registers before 00000000 00001403
[65651.713793] rtl9300_serdes_mac_link_config: registers after 00000000 00001403
[65651.732229] rtl930x_switch_irq link faults: 01ffff00
[65651.737745] rtl930x_switch_irq RX symbol errors: 000001c4
[65651.820237] rtl9300_force_sds_mode: SDS: 6, PHY mode 17
[65651.826078] rtl9300_force_sds_mode: forcing SDS mode 12
[65652.053564] rtl9300_force_sds_mode toggling LC or Ring for 10gr, round 0
[65652.088011] rtl9300_force_sds_mode end power 0x20 0 30
[65652.093756] rtl9300_force_sds_mode -------------------- serdes 6 forced to 12 DONE
[65652.102214] rtl9300_sds_tx_config SerDes 6, pre-amp enable 0, pre-amp val 0, main-amp 9, post-amp enable 1, post-amp val 8, impedance 8
[65652.127797] rtl83xx-switch switch@1b000000 lan9: Link is Up - 2.5Gbps/Full - flow control off
[65652.150932] rtl93xx_phylink_mac_config port 25, mode 0, phy-mode: hsgmii, speed 2500, link 1
[65652.160360] rtl93xx_phylink_mac_config SDS is 7
[65652.166390] rtl93xx_phylink_mac_config CURRENT FORCED MODE 18
[65652.175954] rtl93xx_phylink_mac_config port 24, mode 0, phy-mode: hsgmii, speed 2500, link 1
[65652.185431] rtl93xx_phylink_mac_config SDS is 6
[65652.191494] rtl93xx_phylink_mac_config CURRENT FORCED MODE 18
[65711.428541] rtl93xx_phylink_mac_config port 7, mode 0, phy-mode: xgmii, speed 100, link 1
[65711.437686] rtl93xx_phylink_mac_config SDS is -1
[65711.442835] rtl83xx-switch switch@1b000000 lan8: Link is Up - 100Mbps/Full - flow control off
[65711.453241] rtl930x_switch_irq link faults: 01ffff00
[65711.458770] rtl930x_switch_irq RX symbol errors: 000001c4
[65711.466852] rtl93xx_phylink_mac_config port 7, mode 0, phy-mode: xgmii, speed 100, link 1
[65711.476009] rtl93xx_phylink_mac_config SDS is -1


root@OpenWrt:/# brctl show
bridge name	bridge id		STP enabled	interfaces
switch		7fff.00e04c000000	no		lan1
										lan2
										lan3
										lan4
										lan5
										lan6
										lan7
										lan12
switch3		8000.02e04c000007	no		lan8
											lan9
switch2		8000.02e04c000009	no		lan10
											lan11

My guess is that this is somehow related to the vlans or whatever 'smart config' we have setup, so that's some help I need with figuring out DSA.

However, what I can see now, no crashes (and no packet storms) without the bridge magic, everything also doesn't crash, just tons of packets due to short-circuit obviously ... plugging in/out/in/out stuff from any of the ports causes no faults though.

Edit: So, something funny is happening; not sure yet why; some patch probably that makes things better?
I don't see the logs with 'duplicate address' entry, some kind of smart storm protection? Also I don't see the leds exploding when shortening the ports. What I do see on a ping

64 bytes from 142.250.179.174: seq=1 ttl=117 time=5.601 ms
64 bytes from 142.250.179.174: seq=1 ttl=117 time=5.707 ms (DUP!)
64 bytes from 142.250.179.174: seq=1 ttl=117 time=5.778 ms (DUP!)
64 bytes from 142.250.179.174: seq=1 ttl=117 time=5.836 ms (DUP!)
64 bytes from 142.250.179.174: seq=1 ttl=117 time=5.908 ms (DUP!)

which probably is very correct, but funny. Looks like the ping is returning on both the 2.5G ports and both the 10G ports, so at least that all is working as expected? (it goes out via the USB lan1; then comes back on all shorted ports? Wireshark sees the same, 5 requests where there should be just the one. So all that is good

Btw, I have a development branch with a bunch of patches (most from @plappermaul) to test and move stuff forward with. Can you also try compiling that one to see if the results are any different? https://gitlab.com/olliver/openwrt/openwrt/-/commits/dev/realtek-next (mind you, I'm force-pushing it often)

[lucize]

tried the latest and for me hangs at this

[    0.000000] RTL838X model is 0
[    0.000000] RTL839X model is 0
[    0.000000] RTL93XX model is 93021001
[    0.000000] SoC Type: RTL9302B
[    0.000000] Kernel command line:
[    0.000000] printk: bootconsole [early0] enabled
[    0.000000] CPU0 revision is: 00019555 (MIPS 34Kc)
[    0.000000] MIPS: machine is Zyxel XGS1250-12 Switch
[    0.000000] Initrd not found or empty - disabling initrd
[    0.000000] Using appended Device Tree.

[piaddic7ed]

yep, same here with the realtek-next branch.

[a1ftp]

I experienced some bugs using image 22.03.0 r19685-512e76967f on a Netgear GS308T. I am not sure if this is the correct place to report this. I sysupgraded to the latest snapshot and it fixed the issues. Thanks everyone for your hard work.

[huangjinqiu]

I tried to flash a Netgear GS308T rev 1 (I don't think others exist yet) with OpenWrt 22.03

I used the Maintenance > Update > HTTP Firmware/File Update menu to upload the initramfs image (openwrt-22.03.0-realtek-rtl838x-netgear_gs308t-v1-initramfs-kernel.bin) to Image 1. It said complete so I reboot the switch.

but I lost access to the switch after I rebooted it.

Solid Green Power LED is on after reboot. There are no LED for any ports whichever I plug in the cable. Did I brick the switch?

[slh]

Maybe, it's a bit hard to tell from your description, but it's very likely to be recoverable.

First, just to cover all bases, test connecting via VLAN ID 100 on port 1 and make sure of the exact boot sequence, respectively its LED blinking pattern - probably it just booted up and now waits for you to connect (over the expected IP/ VID). If that doesn't get you further, you might need serial console access - from there (3.3 volts based usb2serial adapter, don't connect Vcc - only GND, rx/ tx) you should be able to recover your device quite easily (and/ or find out what's really happening).

realtek: Add support for Netgear S350 series switches GS308T and GS310TP

https://svanheule.net/switches/gs308t

[huangjinqiu]

Thank you very much!

Can I press reset button to get back to OEM firmware? I am a noob. I don't know how to connect via VLAN ID 100. I googled it but did not get much information about step by step instruction.

[slh]

Support for RTL838x based managed switches

# ip link add link enp2s0 name enp2s0.100 type vlan id 100 # ip link set dev enp2s0.100 up # ip addr add 192.168.1.10/24 dev enp2s0.100 on your client will give you full access to the management interface (well, at least if plugged into port 1), including ssh/ luci, etc.

[huangjinqiu]

Greatly appreciate your detailed guidance. It looks promising. By using the information you provided, I link my laptop to the switch with the network icon appeared the panel. Then how to ssh to the management interface?
#ssh root@192.168.1.10?

[slh]

.1, not .10

[huangjinqiu]

Sorry to ask so many questions. I can't access the management interface. Ethernet Network is disconnected. Is this correct?

[slh]

You need to connect your computer's ethernet cable with lan1 of your switch (wifi disabled), then set a static IP address (e.g. 192.168.1.143, netmask 255.255.255.0) and connect via ssh to 192.168.1.1 - if that doesn't succeed, try the same with VID100 set.

If neither of these succeed, you'll need serial console access, that will (very most likely) succeed - at least to thr bootloader, from where you'll have free reign to revert to OEM or install OpenWrt.

[piaddic7ed]

It will take 2 minutes or so for the link to come up initially. The boot process will most likely show a solid led while still booting. After seeing the solid (green) led wait another 2 minutes.

[   99.067974] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[   99.075520] rtl83xx_fib_event: FIB_RULE ADD/DELL for IPv6 not supported
[  100.828428] RTL8380 Link change: status: 1, ports 100
[  101.711097] rtl83xx-switch switch@1b000000 lan1: Link is Up - 1Gbps/Full - flow control rx/tx
[  101.747944] switch: port 1(lan1) entered blocking state
[  101.753820] switch: port 1(lan1) entered forwarding state

Also, the booted initramfs uses no vlan 100. You can connect to the device as you do with any other openwrt device just minus the dhcp, hence, you'll have to set a static ip on the client.

In order to verify the reports that have arrived lately I took the time to revert my GS108Tv3 to stock and installed openwrt 22.03 initramfs. This is the default config it comes with:

config bridge-vlan 'lan_vlan'
        option device 'switch'
        option vlan '1'
        option ports 'lan1 lan2 lan3 lan4 lan5 lan6 lan7 lan8'

Regarding your client setup. Be reminded that xfce network manager is a bit quirky. After changing ip settings on a connection you need to re-connect (click on the ethernet connection to activate) in order for the settings to become active!

[andyboeh]

IIRC, the patch for the port LEDs didn't make it into 22.03 so it's very well possible that you only get one LED - solid green, then blinking fast, then blinking slowly and after bootup it should be solid green. At the same time, the network connections are enabled and you should be able to connect - also via the web interface as you use a release build.

[olliver]

Let me attach my .config file to see if its not some config issue ...

OpenWRT XGS1210-12 config ($2411714) · Snippets · Olliver Schinagl / OpenWRT...

Also, what switches are you guys using? I'm on an XGS1010-12, using my own U-Boot bin linked before, and actually initramfs booting the XGS1210-12 firmware (not that it matters, other then some labeling/tagging).

Hmm, I just realized that my very last changes actually don't work it hangs after

[    0.000000] clocksource: MIPS: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 4778151116 ns

which could be related to the timer/clock patches from @plappermaul i've integrated (potentially incorrectly).

And I reproduced the [ 0.000000] Using appended Device Tree. hang as well. So, I wasn't booting my modified image (due to new name) but my old one, so that explains that. I'll dive into why it's not working now.

[piaddic7ed]

XGS1010-12, default u-boot, tftp booted. I'm planning to flash once the vlan issues are resolved.
Will happily test your next commits.

[huangjinqiu]

I spent hours trying to no avail. can't ping 192.168.1.1 or 192.168.0.239. No led on ethernet port of my laptop. I reset / reboot switch numerous times. I opened the case and thought the console access is very intimidating.