Suggestion: State the difference between chrony and chrony-nts in package description

abceleung · February 9, 2024, 3:45am

Currently the chrony and chrony-nts package have identical description.

From what I read in this Github issue:
[chrony - RFC] NTS & RTC support not compiled in? · Issue #13835 · openwrt/packages (github.com)
chrony-nts has NTS support while chrony doesn't.
Could this be stated more clearly in both packages' description?

efahl · February 9, 2024, 4:06am

I assume you're referring to the output from opkg info? If so, you should be able to just make a PR on the Makefile:

github.com

openwrt/packages/blob/master/net/chrony/Makefile#L59


      
            DEPENDS+= +PACKAGE_chrony-nts:libgnutls +PACKAGE_chrony-nts:ca-bundle
            VARIANT:=with-nts
          endef
          
          define Package/chrony/description
          	An NTP client and server designed to perform well in a wide range
          	of conditions. It can synchronize the system clock with NTP servers,
          	reference clocks, and manual input using wristwatch and keyboard.
          endef
          
          Package/chrony-nts/description = $(Package/chrony/description)
          
          define Package/chrony/conffiles
          /etc/chrony/chrony.conf
          /etc/config/chrony
          endef
          
          Package/chrony-nts/conffiles = $(Package/chrony/conffiles)
          
          CONFIGURE_ARGS+= \
          	--host-machine=$(shell echo $(GNU_TARGET_NAME) | sed -e 's/-.*//') \

Reguna · February 26, 2024, 5:11pm

I made a PR here. Didn't do any testing though

github.com/openwrt/packages

chrony: update package description

openwrt:master ← regunakyle:chrony

opened 05:09PM - 26 Feb 24 UTC

regunakyle

+8 -2

Maintainer: @mlichvar Compile tested: Not tested Run tested: Not tested …Description: Close this forum topic [Suggestion: State the difference between chrony and chrony-nts in package description](https://forum.openwrt.org/t/suggestion-state-the-difference-between-chrony-and-chrony-nts-in-package-description/187392) (First time doing pull request. Do I need to test this? I can spin up a VM if needed)

system · March 7, 2024, 5:11pm

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.