[Solved] TP-Link RE450v1 wrong mapping of WPS button in 19.07.3

nebulon42 · May 31, 2020, 4:34pm

I have noticed that when pressing the WPS button on the TP-Link RE450v1 it seems to be mapped to the reset button/behaviour.

Capturing the button press with logger "the button was ${BUTTON} and the action was ${ACTION}" gives me "reset" for ${BUTTON}. This seems like a bug, but before reporting it (where exactly? main tracker?) I'd also like to know if I can work around it.

Unfortunately, I don't know enough about the inner workings of the button system apart from that the mapping is apparently done by a kernel module. Can this mapping be changed in userspace or do you have to compile a new kernel for that? Could I change the default action for the reset button? There should be a script somewhere but I don't know where it is.

juppin · May 31, 2020, 5:23pm

According to the mach file in the ar71xx target the wps button triggers the reset event.

github.com

openwrt/openwrt/blob/openwrt-19.07/target/linux/ar71xx/files/arch/mips/ath79/mach-re450.c#L160


		.desc		= "Reset button",
		.type		= EV_KEY,
		.code		= KEY_WPS_BUTTON,
		.debounce_interval = RE450_KEYS_DEBOUNCE_INTERVAL,
		.gpio		= RE450_GPIO_BTN_RESET,
		.active_low	= 1,
	},
	{
		.desc		= "WPS button",
		.type		= EV_KEY,
		.code		= KEY_RESTART,
		.debounce_interval = RE450_KEYS_DEBOUNCE_INTERVAL,
		.gpio		= RE450_GPIO_BTN_JUMPSTART,
		.active_low	= 1,
	},
	{
		.desc		= "Control LED button",
		.type		= EV_KEY,
		.code		= BTN_0,
		.debounce_interval = RE450_KEYS_DEBOUNCE_INTERVAL,
		.gpio		= RE450_GPIO_BTN_LED,

I think this is definitely a bug, but the ar71xx target is deprecated and 19.07 is the last stable release for the ar71xx target.

The bug has to be reported at https://bugs.openwrt.org

You can test if this bug is also on the new ath79 target. But for now there is only a snapshot build for your re450 v1 on the new ath79 target.

nebulon42 · May 31, 2020, 7:15pm

Thank you for the information and also for linking to the specific location. It seems that it has been fixed in the dtsi of the ath79 target: https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/dts/qca9563_tplink_re450.dtsi#L89

I'm now pondering if I should try the snapshot build with imagebuilder or should try to patch it myself and build from source.

juppin · May 31, 2020, 7:59pm

As you see here

github.com

openwrt/openwrt/blob/master/target/linux/ath79/dts/qca9558_tplink_re450-v1.dts#L4


// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
/dts-v1/;

#include "qca9558_tplink_rex5x.dtsi"

/ {
	compatible = "tplink,re450-v1", "qca,qca9558";
	model = "TP-Link RE450 v1";
};

the dtsi file is

github.com

openwrt/openwrt/blob/master/target/linux/ath79/dts/qca9558_tplink_rex5x.dtsi

// SPDX-License-Identifier: GPL-2.0-or-later OR MIT

#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>

#include "qca955x.dtsi"

/ {
	chosen {
		bootargs = "console=ttyS0,115200n8";
	};

	aliases {
		led-boot = &led_power;
		led-failsafe = &led_power;
		led-running = &led_power;
		led-upgrade = &led_power;
		mdio-gpio0 = &mdio2;
		label-mac-device = &eth0;
	};

This file has been truncated. show original

nebulon42 · June 1, 2020, 6:54am

I found a workaround. In order to restore the default behaviour you have to swap the files /etc/rc.button/reset and /etc/rc.button/wps. Any custom functionality on WPS button press can then go into /etc/rc.button/reset. In order for the changes to survive a factory reset one would have to make a custom build.

system · June 11, 2020, 6:54am

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.