Yes that is correct, i changed the init script to take care of this and set the netbios name to the hostname (the current snapshot version has this change). The "hostname" setting field in luci is not used anymore and i need to update the UI package as well.
As noted thats a side-effect from switching from netbios to wsd. MacOS uses mdns via avahi, which takes care of the correct nameing.
Apparently that is your hostname and domain, for your router, under it you should see your shares. That's announced by wsdd2, via the netbios name option, which needs to match now, to browse shares by name.
Yes you probably have a older samba4 build, this should be fixed in the latest snapshot ones. I changed the logic and now always use hostname.domain, the luci samba hostname field is ignored now.
Um, than something is broken yet again, dammit.
I use router.lan as hostname/domain combo and can see, access this path just fine under windows. Can you check the set hostname, domain/suffix of your router and whats set via netbios name in the smb.conf?
What is the error you get under windows? You should be able to access this path normally, can you ping the router using the FQDN ?
So there is an extra '.' at the end of the domain? The problem i had is that the hostname tool is not build by default, so i did what most other packages do and grabbed the values directly via uci from the configs.
Can you verify what cat /proc/sys/kernel/hostname and cat /proc/sys/kernel/domainname would print?
PS: PR is out, hopefully this finally solves your issue and thanks for the reports.