Rpcd services documentation

stokito · February 10, 2024, 7:52pm

On Wiki we have a page with list of RPCD services exposed over UBUS and their description:
https://openwrt.org/docs/guide-developer/ubus

This is basically same as ubus -v list service .
The problem is that some methods/commands aren't clear by their name.
For example in the service state has params:
"state":{"spawn":"Boolean","name":"String"}

And I expected that this is method returns a current state of a service: running, disabled.

But from sources it looks like a completely different thing

github.com

openwrt/procd/blob/7e6c6efd6fbcc7955801c5e2ac915a90697e1fd9/service/service.c#L617


      
          	in = vlist_find(&s->instances, blobmsg_data(cur), in, node);
          	if (!in) {
          		ERROR("instance %s not found\n", blobmsg_get_string(cur));
          		return UBUS_STATUS_NOT_FOUND;
          	}
          
          	return service_handle_kill(in, sig);
          }
          
          static int
          service_handle_state(struct ubus_context *ctx, struct ubus_object *obj,
          		     struct ubus_request_data *req, const char *method,
          		     struct blob_attr *msg)
          {
          	struct blob_attr *tb[__SERVICE_STATE_ATTR_MAX];
          	struct service *s;
          	struct service_instance *in;
          	bool container = is_container_obj(obj);
          	int spawn;
          
          	blobmsg_parse(service_state_attrs, __SERVICE_STATE_ATTR_MAX, tb, blobmsg_data(msg), blobmsg_data_len(msg));

Can anyone update the wiki page and add more description:
https://openwrt.org/docs/guide-developer/ubus/service