This will result in the 192.168.1.0/24 network being untagged on eth0, and 192.168.10.0/24 tagged with VLAN ID 10.
You can delete this:
Then, on your managed switch, you need to setup the uplink port (the one that connects to the router) as a trunk with the same tagging configuration (VLAN 1 untagged, VLAN 10 tagged). From there, you'll setup access ports for VLANs 1 and 10 -- these are ports that directly connect to computers or other equipment and they carry just one VLAN, untagged.
To achieve the managed switch configuration, look at the documentation of your switch to learn how this is done.
Once that is properly configured, the router will perform the routing as intended.
I just saw this post and wondered if I might be of some help as I run 10 class, 192 and 172 class from the one system with restricted communications between on 4 NICs.
One thing I'm wondering is what is being attempted here on what hardware?
How many NICs are being used in what way?
I don't know what hardware the OP is using, but it appears that there are only 2 ethernet ports total (one is allocated to the wan, the other to the lans).
@AlexeiK - what is the output of ubus call system board?
I'm not making this up. This is the whole purpose of a managed switch is to be able to handle the VLANs. Otherwise, you have no ability to set port-VLAN assignments and keep the traffic for each VLAN separated.
Ahh, okay, 2 ports only does make it a bit harder.
VLAN would be the only way to go for some semblance of separation.
If the 2 bridges are set up for things on the ETH1, then that can also allow for the connection between the IPs using one simple forwarding ability. I actually did that at first before I got my 4 port adaptor installed.
The forwarding could then also be restricted to only that one machine.
Fundamentally, each subnet needs to be connected to its own physical (or virtual) interface/port. You are only permitted to have a single untagged network on a physical port. Using VLANs allows you to have one or more tagged networks on the port so that the 2 or more total networks don't conflict. The managed switch then allows you to set port-VLAN assignments such that devices are connected to the desired subnet.