Problem with IF

[gifrigio93]

Hi,
i'm new and i'm coding a little bash for serial check:

#!/bin/sh
#!/bin/bash
serial=$(grep -w "Serial" /proc/cpuinfo)
match="Serial          : 000000000ca1d574"
if [ $serial = $match ] ; then
echo "ok"
else
echo "no"
fi

But if i run sh ./filename.sh i've this error:

./filename.sh: line 11: syntax error: unexpected "fi" (expecting "then")

why? you can help me

Thank you.

[faser]

@gifrigio93

if [ $serial = $match ] ;

Tried without the space before the ;

[vgaetera]

@gifrigio93

if [ $serial = $match ] ; then

if [ "$serial" = "$match" ] ; then

[gifrigio93]

i've tryed to make this change but i get the same error:

filename.sh: line 9: syntax error: unexpected "fi" (expecting "then")

#!/bin/sh
#!/bin/bash
serial=$(grep -w "Serial" /proc/cpuinfo)
match="Serial          : 000000000ca1d574"
if [ "$serial" = "$match" ] ; then
echo "ok"
else
echo "no"
fi

[hnyman]

@gifrigio93

i'm coding a little bash

Have you installed bash?
(By default there is only ash from busybox providing sh functionality, but no bash compatibility)

And in any case, you have conflicting double shebang:

@gifrigio93

#!/bin/sh
#!/bin/bash

Both sh and bash defined ????

[gifrigio93]

ok i've modified the sh:

#!/bin/sh
serial=$(grep -w "Serial" /proc/cpuinfo)
match="Serial          : 000000000ca1d574"
if [ "$serial" = "$match" ] ; then
echo "ok"
else
echo "no"
fi

root@Speezy:~# sh ./filename.sh
./filename.sh: line 8: syntax error: unexpected "fi" (expecting "then")

[vgaetera]

https://en.wikipedia.org/wiki/Newline#Conversion_between_newline_formats

[gifrigio93]

Thank you!