Patch submission when you are not the author

Bit of an odd one and I have had a look at but as it is not my patch to submit, but it does solve an issue with the device I am using, I was wondering how this is dealt with.

The R4S is still only available in snapshot. (I've been using the builds from NanoPi R4S rk3399 4G is a great new OpenWrt device)

Someone else is using snapshots and has pointed out that the R4S still has the reboot bug but ImmortalWrt has fixed this issue with this patch -

What is the best way to get this merged as a commit for OpenWrt?

This one is an example

This is not my patch, I just copied full commit as a .patch file and sent it to OpenWRT

1 Like

The right way is to ask the original author for permission to submit his code for inclusion in OpenWrt. And copy him/her in when doing so.

1 Like

Thats basically what I was wondering. The code obviously works and ImmortalWrt is a clone of OpenWrt.

But its just become a moot point as someone has submitted the patch or one very similar.

1 Like

And he's got in shit for it and deleted it.

This is why i asked here to avoid drama like that.

Debating filing a bug and pointing at the original patch and letting them decide what to do.

A crucial aspect of free software is that users are free to cooperate. It is absolutely essential to permit users who wish to help each other to share their bug fixes and improvements with other users.

Some have proposed alternatives to the GPL that require modified versions to go through the original author. As long as the original author keeps up with the need for maintenance, this may work well in practice, but if the author stops (more or less) to do something else or does not attend to all the users' needs, this scheme falls down. Aside from the practical problems, this scheme does not allow users to help each other.

Sometimes control over modified versions is proposed as a means of preventing confusion between various versions made by users. In our experience, this confusion is not a major problem. Many versions of Emacs have been made outside the GNU Project, but users can tell them apart. The GPL requires the maker of a version to place his or her name on it, to distinguish it from other versions and to protect the reputations of other maintainers.

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.