Default config file for pptpd lacks logwtmp option

ktns · July 4, 2017, 4:20am

Hi.

I was installing pptpd on my LEDE 17.01.2 box and noticed pptpd did not start complaining "sh: out of range".
After a bit of investigation, "$uci set pptpd.pptpd.logwtmp=0" solved the problem but I don't know
if "0" is a neat setting.

Would you please provide the proper default value for logwtmp in /etc/config/pptpd?

feckert · July 4, 2017, 6:20am

This has to to with this validation check in the init script. I dont know why this is an uinteger value! It would be better to set it to an boolean.

github.com

openwrt/packages/blob/master/net/pptpd/files/pptpd.init#L18


CONFIG=/var/etc/pptpd.conf
CHAP_SECRETS=/var/etc/chap-secrets
OPTIONS_PPTP=/var/etc/options.pptpd


validate_login_section() {
	uci_validate_section pptpd login "${1}" \
		'username:string' \
		'password:string'
}


validate_pptpd_section() {
	uci_validate_section pptpd service "${1}" \
		'enabled:uinteger' \
		'localip:string' \
		'remoteip:string' \
		'mppe:list(string):required no40 no56 stateless' \
		'logwtmp:uinteger'
}


setup_login() {
	validate_login_section "${1}" || {

If value is set to 1 it will be echoed into the configuration if not then do nothing.

github.com

openwrt/packages/blob/master/net/pptpd/files/pptpd.init#L55


	}


	[ "$enabled" -eq 0 ] && return 1


	mkdir -p /var/etc
	cp /etc/pptpd.conf $CONFIG
	cp /etc/ppp/options.pptpd $OPTIONS_PPTP


	[ -n "$localip" ] && echo "localip  $localip" >> $CONFIG
	[ -n "$remoteip" ] && echo "remoteip  $remoteip" >> $CONFIG
	[ "$logwtmp" -eq 1 ] && echo "logwtmp" >> $CONFIG


	echo "mppe $(echo $mppe | sed -e 's/\s/,/g')" >> $OPTIONS_PPTP


	return 0
}


start_service() {
	config_load pptpd
	setup_config pptpd || return
	config_foreach setup_login login

camelcamro · January 25, 2018, 9:13am

that is still not fixed.
how to fix it permantly ?
tried to set in /etc/pptpd.conf
wtmp 0

but still not working ... hmm