Comfast E314N-V2

grosjo · February 2, 2019, 2:03pm

Hi

Has this patch for Comfast E314N-V2 pulled into the git of OpenWrt ?

https://patchwork.ozlabs.org/patch/884850/

jeff · February 2, 2019, 3:41pm

Ok, so maybe it didn't get closed out

https://openwrt.org/toh/start?dataflt[Brand*~]=comfast -- nope

Ok, so maybe the ToH didn't get updated. Geeze, you've got the patch, so you know what you're looking for and where

jeff@deb-devel:~/devel/openwrt/target/linux/ar71xx$ fgrep -r e314n .
jeff@deb-devel:~/devel/openwrt/target/linux/ar71xx$

Nope

tmomas · February 2, 2019, 5:30pm

What update do you expect?

jeff · February 2, 2019, 6:04pm

(Just showing the path I used to confirm device wasn’t supported.)

Borromini · February 2, 2019, 7:45pm

@grosjo It looks like the author did file the patch for inclusion but there was no follow-up (nothing further on the mailing list).

I can try to apply the patch to the current codebase (18.06.2 or master) and build you an image if you'd like (so you can test) - but that means you should be able to recover if needed (the author no doubt tested his patch but if it breaks it breaks, and you get to keep all the pieces).

Keep in mind all ar71xx supported devices need to be migrated to ath79 (DTS-based) at some point and this patch 'only' provides ar71xx support. I don't have the skillset to turn this into an ath79 patch, but once you have ar71xx up and running on yours you might apply here and maybe someone is kind enough to pick up your request.

Let me know.

grosjo · February 2, 2019, 11:33pm

@borromini, thanks for the note.

I would appreciate if the patch gets into master.

I maybe be able to test it probably in a month or so.

As for migrating to Ath79, I can put some effort in this. I tried to go through the 890 comments on the topic ij the forum, but is there a formal documentation somewhere about it ?

jeff · February 3, 2019, 4:58am

Additionally:

Partitions should have node labels of partition@<start address>

Boot loader, art, and similar critical partitions marked read-only

"firmware" mtd label for NOR, "ubi" for NAND, can't both be present, however

Auto-splitting "firmware" partition (by its name) is enabled by:
CONFIG_MTD_SPLIT_FIRMWARE

If you use a proper compatible string it doesn't has to be named
"firmware" and you don't need CONFIG_MTD_SPLIT_FIRMWARE

Tab indentation

cpp-style #include (not device tree /include/)

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst

Borromini · February 4, 2019, 11:15am

Understandably. Since it's a bit stale at this point that would mean you'd need to test it and report to the mailing list for follow-up. You might try prodding the author if needed.

grosjo · February 25, 2019, 11:03pm

First I will ensure the ar71xx is working.

New repo here : https://github.com/grosjo/openwrt-comfast-e314n-v2/

grosjo · February 28, 2019, 1:40pm

Pull request made

grosjo · March 2, 2019, 7:15am

ok, my pull request has been refused. How frustrating.

And sill no clue how to port this ti "ath79". Isn't there a RTFM somewhere ?

jeff · March 2, 2019, 7:51am

In the main, since your device seems very similar to others, see how their DTS is created through #include statements, learn how to add/remove/modify DTS nodes and properties, and do it. There doesn’t look to be much involved from the changes in the mach file.

grosjo · March 2, 2019, 8:16am

Yes, but actually all other simialr e316n, e320n, etc.. are in ar71xx , not in ath79

So, somehow, I need to know how does the ar71xx -> ath79 process works. Isn't there a doc somewhere ?

tmomas · March 2, 2019, 8:41am

Take a look at Porting guide ar71xx to ath79?

grosjo · March 30, 2019, 6:19pm

Plese kindly review

anon4457646 · May 10, 2019, 8:31pm

any news about this device?

grosjo · May 11, 2019, 8:05am

PR is here : https://github.com/openwrt/openwrt/pull/1955

All is working fine, I am just a bit desesperate to find some admin willing to push it to master

jeff · May 11, 2019, 8:19am

People wishing to build based on your PR can always download a patch from https://patch-diff.githubusercontent.com/raw/openwrt/openwrt/pull/1955.patch (add .patch to the PR URL). It then can be locally applied with something like git am 1955.patch. I would suggest checking out a new branch before applying the patch, rather than applying it directly to the local copy of master.

Edit:

The above URL comes from taking the PR URL https://github.com/openwrt/openwrt/pull/1955 and adding the .patch extension to get https://github.com/openwrt/openwrt/pull/1955.patch (which then redirects to the patch content URL, shown above).

grosjo · May 11, 2019, 8:02am

PR is here : https://github.com/openwrt/openwrt/pull/1955

All is working fine, I am just a bit desesperate to find some admin willing to push it to master

grosjo · May 11, 2019, 10:17am

@jeff thank you for the tip
however, do you know the process to convert this PR into master code ?