Calling `service` vs `/etc/init.d/`

stangri · November 12, 2022, 4:36am

On OpenWrt 22.03.2 when I run /etc/init.d/simple-adblock check domain.com the check() function in my init script receives the domain.com as a parameter and works fine.

However if I run service simple-adblock check domain.com the check() function in my init script does not receive any parameters and fails.

Is there anything I can do to make it work with the service call?

slh · November 12, 2022, 4:45am

Not really, aside from extending procd accordingly:

github.com

openwrt/openwrt/blob/master/package/system/procd/files/service

#!/bin/sh

main() {
	local service="$1"
	local cmd="$2"

	local boot status

	if [ -f "/etc/init.d/${service}" ]; then
		/etc/init.d/"${service}" "${cmd}"
		exit "$?"
	fi

	if [ -n "$service" ]; then
		echo "Service \"$1\" not found:"
		exit 1
	fi

	echo "Usage: $(basename "$0") <service> [command]"
	for service in /etc/init.d/* ; do

This file has been truncated. show original

(only $1 and $2 are looked at)

hnyman · November 12, 2022, 5:38am

Using quotes to combine the remaining arguments into one single argument?

service simple-adblock "check domain.com"

Not sure if that would work, but you might try.

slh · November 12, 2022, 5:43am

It won't, as it then consider the string to be executed as a single binary (with spaces in the name). Changing procd's service command/ script would need changing - or the user has to realize that OpenWrt isn't RedHat…

stangri · November 12, 2022, 9:09pm

@slh, @hnyman, thank you gentlemen, I'll create a PR on github, hopefully someone will merge it to the main repo.

hnyman · November 12, 2022, 9:18pm

You are late...