Bug or feature? PPPoE WAN with WED on mt7915e disables HW flow offload on mt7622 (OpenWrt 22.03, 23.05.0-rc2, SNAPSHOT)

Before filing a new issue on GitHub I'd like to ask $subject.

My ISP uses PPPoE, I have a Xiaomi AX3200 (mediatek/mt7622 with mt7915e wireless), it supports flow_offloading_hw '1' and mt7915e wed_enable=Y.

Testing with OpenWrt 23.05-SNAPSHOT r23314-7efec0acca

wed_enable=Y

# uci show network.wan.proto
network.wan.proto='pppoe'
# grep mt7915e /etc/modules.conf 
options mt7915e wed_enable=Y
# dmesg|grep wed
[    6.640718] mt7915e 0000:01:00.0: attaching wed device 0 version 1

Checking if hardware offload is working

Warning from fw4:

# fw4 check
Hardware flow offloading unavailable, falling back to software offloading
Ruleset passes nftables check.

No entry in /sys/kernel/debug/ppe0/bind:

# wc -l /sys/kernel/debug/ppe0/bind 
0 /sys/kernel/debug/ppe0/bind

wed_enable=N

# uci show network.wan.proto
network.wan.proto='pppoe'
# grep mt7915e /etc/modules.conf 
options mt7915e wed_enable=N
# cat /sys/module/mt7915e/parameters/wed_enable 
N

Checking if hardware offload is working

fw4 doesn't warn:

# fw4 check
Ruleset passes nftables check.

/sys/kernel/debug/ppe0/bind has entries:

# wc -l /sys/kernel/debug/ppe0/bind 
6 /sys/kernel/debug/ppe0/bind

Practically this is just a repost of @openx' findings back from December 2022, with OpenWrt 22.03.2

IMHO this is a bug, so HW flow offload and WED should work with PPPoE WAN too, not just DHCP WAN.

1 Like