Belkin RT3200/Linksys E8450 WiFi AX discussion

omijh · April 18, 2022, 2:04pm

yup, I can confirm I had my 5ghz channel stop & unable to connect today with OpenWrt SNAPSHOT r19421-3aa96efa24

modzilla · April 18, 2022, 2:22pm

While I had problems with 5Ghz yesterday a simple restart of the network interface via LUCI solved it. Luckily I have a wireguard vpn from which I can access my Router to do that without connectivity.

MeIsReallyBa · April 18, 2022, 4:14pm

I have fixed the pppoe hw offload. Now the cpu usage is zero during speedtest.

github.com

openwrt/openwrt/blob/e20de224427008e0f26161f924bc347d974fd15a/target/linux/generic/hack-5.10/650-netfilter-add-xt_FLOWOFFLOAD-target.patch#L252

      
        
            +restart:
            +	spin_lock_bh(&hooks_lock);
            +	hlist_for_each_entry(hook, &table->hooks, list) {
            +		if (hook->used || !hook->registered) {
            +			active = true;
            +			continue;
            +		}
            +
            +		hlist_del(&hook->list);
            +		spin_unlock_bh(&hooks_lock);
            +		if (table->ft.flags & NF_FLOWTABLE_HW_OFFLOAD)
            +			table->ft.type->setup(&table->ft, hook->ops.dev,
            +					      FLOW_BLOCK_UNBIND);
            +		nf_unregister_net_hook(hook->net, &hook->ops);
            +		kfree(hook);
            +		goto restart;
            +	}
            +	spin_unlock_bh(&hooks_lock);
            +
            +	return active;
            +}

I also deleted 252-254. 252-254 seems to make kernel oops sometimes.

daniel · April 18, 2022, 11:59pm

Very nice! Are you planning to submit this as a patch or PR to OpenWrt?

Dopam-IT_1987 · April 19, 2022, 1:33am

good evening everyone is there a difference between 21.02.3 and 22.03 and is the belkin now compatible with 21.02.3? thank you in advance

https://downloads.openwrt.org/releases/21.02.3/

hnyman · April 19, 2022, 4:43am

Yes. Forthcoming 21.02.3 is a just maintenance release from the old 21.02 branch.

No.
21.02.3 is still mainly the same code from February 2021, with a few more bug fixes than 21.02.2

22.03.0 will be the new major release, and will support this device.

See the current branches below. Hopefully this clarifies the situation for you

MeIsReallyBa · April 19, 2022, 3:02pm

This is part of pppoe hw offload patch. Another part is https://github.com/MeIsReallyBa/openwrt/commit/7d09a0f2284d6acc476a81490083b8e2de013ba4.

I will consider to make a pr after several day's test. But I feel the pr process is even difficult in somewhere.

daniel · April 19, 2022, 4:20pm

Yeah, that doesn't look so good, as instead of turning the if into a noop (as both branches now return true) it should then rather be removed entirely. As I don't understand it: Can you explain why this is needed?
@nbd any idea how to get flow offloading with PPPoE working in a clean way (and hopefully without breaking something else)?

MeIsReallyBa · April 19, 2022, 10:54pm

From my understanding, there are two problems that broke the pppoe hw offload.

1.PPPOE can't pass the dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN check. It will return here. I used to mention it here.

github.com/openwrt/openwrt

MT7622 hardware flow offload not work in pppoe

opened 02:52AM - 22 Mar 22 UTC

closed 02:34AM - 18 Apr 22 UTC

MeIsReallyBa

target/mediatek

I'm using latest master source Code with redmi ax6s(mt7622+mt7915). I find that… hw flow offload works in dhcp environment but failed in pppoe. I add a printk like this: https://github.com/MeIsReallyBa/openwrt/blob/5c22d69606110ce8f23b00e54dc84ebeecdc7bbd/target/linux/generic/hack-5.10/650-netfilter-add-xt_FLOWOFFLOAD-target.patch#L360 dmesg keeps shows:test 512 I make a search and found that 512 means ARPHRD_PPP . Is this a bug or it is caused by my setting ?

2.There is no valid resoure address with pppoe. we can see that both resource and dest address are created in linux 5.4 version but now there is only dest address.

github.com

openwrt/openwrt/blob/39f1815b3eee1a7057d0475c9ac193e7e52e0bb9/target/linux/generic/pending-5.4/644-net-pppoe-support-hardware-flow-table-offload.patch#L94

      
        
            +	struct sock *sk = (struct sock *)chan->private;
            +	struct pppox_sock *po = pppox_sk(sk);
            +	struct net_device *dev = po->pppoe_dev;
            +
            +	if (sock_flag(sk, SOCK_DEAD) ||
            +	    !(sk->sk_state & PPPOX_CONNECTED) || !dev)
            +		return -ENODEV;
            +
            +	path->dev = po->pppoe_dev;
            +	path->flags |= FLOW_OFFLOAD_PATH_PPPOE;
            +	memcpy(path->eth_src, po->pppoe_dev->dev_addr, ETH_ALEN);
            +	memcpy(path->eth_dest, po->pppoe_pa.remote, ETH_ALEN);
            +	path->pppoe_sid = be16_to_cpu(po->num);
            +
            +	if (path->dev->netdev_ops->ndo_flow_offload_check)
            +		return path->dev->netdev_ops->ndo_flow_offload_check(path);
            +
            +	return 0;
            +}
            +#endif /* CONFIG_NF_FLOW_TABLE */
            +

github.com

openwrt/openwrt/blob/7a732213322d9aa6d8743beffb185ca6f53a5bea/target/linux/generic/backport-5.10/610-v5.13-15-net-ppp-resolve-forwarding-path-for-bridge-pppoe-dev.patch#L71

      
        
            +	struct pppox_sock *po = pppox_sk(sk);
            +	struct net_device *dev = po->pppoe_dev;
            +
            +	if (sock_flag(sk, SOCK_DEAD) ||
            +	    !(sk->sk_state & PPPOX_CONNECTED) || !dev)
            +		return -1;
            +
            +	path->type = DEV_PATH_PPPOE;
            +	path->encap.proto = htons(ETH_P_PPP_SES);
            +	path->encap.id = be16_to_cpu(po->num);
            +	memcpy(path->encap.h_dest, po->pppoe_pa.remote, ETH_ALEN);
            +	path->dev = ctx->dev;
            +	ctx->dev = dev;
            +
            +	return 0;
            +}
            +
             static const struct ppp_channel_ops pppoe_chan_ops = {
             	.start_xmit = pppoe_xmit,
            +	.fill_forward_path = pppoe_fill_forward_path,
             };

daniel · April 19, 2022, 10:57pm

So we should reopen https://github.com/openwrt/openwrt/issues/9531 I supposed, right?

MeIsReallyBa · April 20, 2022, 2:33am

I remixed the patch of nbd, now we don't need any other modification, just add this patch to make pppoe hw offload take effect. I'll reopen that issue after I'm sure there's no problem with this patch.

github.com

MeIsReallyBa/openwrt/blob/master/target/linux/mediatek/patches-5.10/999-fix-pppoe-flowoffload.patch

--- a/net/netfilter/xt_FLOWOFFLOAD.c	2022-04-20 07:17:12.515991000 +0800
+++ b/net/netfilter/xt_FLOWOFFLOAD.c	2022-04-20 07:45:03.874095949 +0800
@@ -222,13 +222,31 @@
 	return false;
 }
 
-static bool flow_is_valid_ether_device(const struct net_device *dev)
+
+static void
+xt_flowoffload_get_dest_macaddr(u8 *dest, const struct dst_entry *dst,
+				const void *daddr)
 {
-	if (!dev || (dev->flags & IFF_LOOPBACK) || dev->type != ARPHRD_ETHER ||
-	    dev->addr_len != ETH_ALEN || !is_valid_ether_addr(dev->dev_addr))
-		return false;
+	struct net_device *dev = dst->dev;
+	struct neighbour *n;
+	u8 nud_state;
+
+	memset(dest, 0, ETH_ALEN);

This file has been truncated. show original

quarky · April 20, 2022, 4:49am

I suppose your patch should be placed in /target/linux/generic instead of /target/linux/mediatek? It should apply for mt7621 routers using mt7530 switches. In fact, any router using mt753x switches should work.

MeIsReallyBa · April 20, 2022, 4:54am

I placed it in Mediatek folder just because I haven't test it with mt7621 although it should also work for mt7621.
In fact hwnat module is only about ppp engine which isn't in switch.
I‘m still use swconfig in mt7622 instead of dsa as there still some bugs with dsa. Luckily hwnat works properly with swconfig.

quarky · April 21, 2022, 3:04am

I stand corrected.

I'll be testing your PPPoE patch on my Linksys EA7500v2 mt7621 router using the latest master repo. Need some pointer from you. Do I need to switch back to firewall3 since the default now is firewall4? I remember reading somewhere that firewall4 does not support h/w offloading?

MeIsReallyBa · April 21, 2022, 3:15am

Yes, my patch is based on xt_flow_offload which firewall3 is using.

Gix · April 21, 2022, 10:59am

Many thanks for your contribution. I used your new patch (slighty modified) with a new 5.15 build and indeed the CPU usage is close to zero when using an ethernet-connected client (previously the CPU usage was even higher than for WLAN clients).
But for WLAN clients the CPU usage is still the same like your previous fix for PPPoE (with wed enabled), about 25% when download and 50% when uploading. Also I noticed after the ethernet test that the bridger process started to consume 50% CPU so I restarted it, don't know what caused this. I really hope now that you've managed to discover the PPPoE issue, Felix will look into it and make a final hw offloading patch that applies also to PPPoE and doesn't break other packages.

MeIsReallyBa · April 21, 2022, 11:15am

It's normal that wan->wifi consume 25% cpu. Stock firmware also consume some cpu usage during wan->wifi test. This patch only fix the wire performance issue.

Bridger is only about lan->wifi offload. If it works, you can see some bind from cat /sys/kernel/debug/mtk_ppe/bind during lan->wifi speedtest.

github.com

MeIsReallyBa/immortalwrt/blob/72b62f91aa3ffd9bd692ea682fed1de12db3e292/package/network/services/bridger/files/bridger.conf#L3


      
          config defaults
          	# example for blacklisting individual devices or bridges
          	list blacklist eth0

The default profile needs to be modified (delete # like this) to make bridger works correctly. I haven't meet the situation that bridger process consumes a lot of cpu usage.

Dopam-IT_1987 · April 21, 2022, 4:56pm

i have download a last version for rt3200 work very well

the packages is donwloadable everywhere with this version you know ?

openwrt 22.03.0 rc1 e19302

atiensivu · April 21, 2022, 6:19pm

Anyone know when we'll get brave and swap out 5.10 for 5.15 for these chipsets by default for master? Seems like it is pretty stable but I'm sure I'm not touching sections that other people do (like PPPoE).

edofullin · April 22, 2022, 10:23am

Hi, does anyone know if RT3200 support jumbo frames wan-side (I need 1540 MTU to overcome encapsulation overhead)?

If it does not, is it a driver or hardware issue?

I tried raising MTU in luci but it seems not working well