Support for D-Link DIR-842 (Rev C2)

For Developers
116

Sure, I am putting it on github, I am not very familiar with git so please give me 30 minutes to do it, thanks!

117

git push github-remote-name local-branch-name:remote-branch-name

is helpful. At least for me, not calling the branch master is helpful.

118

Here is it:

119

gpio-export is deprecated -- what are you trying to accomplish here?

	gpio-export {
		compatible = "gpio-export";
		#size-cells = <0>;

 		gpio_switch_reset {
			gpio-export,name = "dir-842-c2:reset:switch";
			gpio-export,output = <1>;
			gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
		};
	};
};

gpio-hog is a supported choice for pulling a "random" line up or down at kernel start.

120

This is the code I copied from dir-859 dts file

I think this is to make the reset key work so I leave it in, unfortunately I dont know what it does also...

121

Running sysupgrade after factory is wrong. If it is required, then your factory image is wrong.

1 Like
122

Check behavior with it removed. If still required, change to gpio-hog.

123

Thanks, but can you explain more?
This installation method is the same as DIR 859 also, so I thought it is correct.

124

I never met this flash procedure. If it is OK for Openwrt maintainers, then OK.

1 Like
125

Reset button not working after I removed it

so I changed it to gpio-hog

tested, reset button working, Thanks!

126

Cool -- the "double negative" there is a little confusing to me to read and understand the intent.

If it is that it needs to be "voltage on" at boot, then maybe

	reset-button {
		gpio-hog;
		output-high;
		gpios = <11 GPIO_ACTIVE_LOW>;
		line-name = "reset-button";
    };

might be clearer?

output-high, at least for me, tells me the intended state is "logical active" at the consumer.

(Also, while "name" is a string property, making it "unbreakable" by shell tokenization is considered by many to be good practice.)

127

Thanks, I agree that your way is clearer to understand

128

What about wired mac addresses? Are they OK?

129

Ya they are OK now.
I actually submitted a PR already.

130

Hi,

There's Dir-842 c1 that comes without USB port.

Possible to include support for C1?

Thank you

1 Like
131

Cross posting s link to this thread there....

If anyone has a C1 and can build and test and provide feedback... do so.... then ask @jackcolentern in that thread if you have constructive input that he/she can work with. Or if you can send him/her one... do that too!

1 Like
133

Yes, C2 images works on C1 as well.

We can continue the conversation on the C1 thread

1 Like
134

Today I got my hands on a C3 (or maybe C3EU). I created Support for D-Link DIR842 (Rev C3) - Maybe EU version? for the discussion.

I also posted on the Rev C1 thread

135

Thank you for your share! I learned a lot here!

136

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.