R7800 - No Wi-fi LEDs in OpenWrt 18.06.0-rc2 r7141

Hi,
I’ve just installed the above firmware, and i cannot get the 2.4 or 5g Wi-fi leds to work, anyone else having the same issue? Everything else seems to working fine at the moment.
Regards

(Full) Support for WLAN LEDs controlled by ath10k GPIOs (as used in the r7800) is only present in master, not the openwrt-18.06 branch (3 crucial commits missing), the necessary additions have a rather large impact on all devices with ath10k WLAN (including those that did have functioning WLAN LEDs (as in controlled by SOC GPIOs, instead of ath10k GPIOs) before) and have only been submitted and merged after 18.06 was branched off; it won't get backported to 18.06.

This isn't a regression and hasn't worked in 17.01.x either.

2 Likes

@slh, do you know if they’ll make it to the final release of 18.06.0?

They won't, see the following pull request for details.

The necessity for fix-up patches like the one I requested there demonstrates the regression potential of last minute changes affecting a large number of devices (including those that did work before) quite nicely.

Got it. Makes sense.

It is rather easy to backport R7800 Wifi LED support into 18.06, if you build your own version.

1 )
You need the commit from stintel enabling the config symbol:
https://github.com/openwrt/openwrt/commit/34e22653ac18b6ac7fd368ca47625f665808067f

2 )
You also need to define the LED trigger, either by creating a default trigger (like in https://github.com/openwrt/openwrt/commit/60deb3cdef4ac50a7d0fe9964a0f4a55aca1567e , or you can define the LEDs in /etc/config system via LED detection in /etc/board.d/01_leds:

--- a/target/linux/ipq806x/base-files/etc/board.d/01_leds
+++ b/target/linux/ipq806x/base-files/etc/board.d/01_leds
@@ -51,6 +51,15 @@ zyxel,nbg6817)
    ;;
 esac
  
+case "$board" in
+netgear,r7800)
+  ucidef_set_led_wlan "wlan2g" "WLAN 2G" "ath10k-phy1" "phy1tpt"
+  ucidef_set_led_wlan "wlan5g" "WLAN 5G" "ath10k-phy0" "phy0tpt"
+  ;;
+*)
+  ;;
+esac
+
 board_config_flush
  
 exit 0

I have backported them into my community build, and LEDs work just nicely.