Quirks/Oddities you will encounter with Asus RT-AX53U

The Power LED isn't properly defined in the dts (?) I don't know what's the proper way to do it but it seems to work properly with my edits.
The USB LED isn't defined in the dts either.
Reading around the forum, the LEDs for MT7915 aren't implemented yet, there's an open issue too in mt76: Please add support for wlan 2,4 and 5 GHz leds on Asus rt-ax-53u #705 following links from there gets confusing.
I'm guessing we need this patch first? [v3] mt76: mt7915: add LED support
LE: we have this: mt76: mt7915: add LED support so something else is missing.
Anyway, for what I could "fix", the Power and USB LED patch (for the current master):

diff --git a/target/linux/ramips/dts/mt7621_asus_rt-ax53u.dts b/target/linux/ramips/dts/mt7621_asus_rt-ax53u.dts
index aec8a0494d..90004b0426 100644
--- a/target/linux/ramips/dts/mt7621_asus_rt-ax53u.dts
+++ b/target/linux/ramips/dts/mt7621_asus_rt-ax53u.dts
@@ -27,10 +27,20 @@
 		compatible = "gpio-leds";
 
 		led_power: led-0 {
+			label = "blue:power";
 			color = <LED_COLOR_ID_BLUE>;
-                        function = LED_FUNCTION_POWER;
+			function = LED_FUNCTION_POWER;
 			gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
 		};
+
+		usb: led-7 {
+			label = "blue:usb";
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_USB;
+			gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
+			trigger-sources = <&ehci_port2>;
+			linux,default-trigger = "usbport";
+		};
 	};
 
 	keys {
diff --git a/target/linux/ramips/image/mt7621.mk b/target/linux/ramips/image/mt7621.mk
index 943fc62ecd..43d95f1e5c 100644
--- a/target/linux/ramips/image/mt7621.mk
+++ b/target/linux/ramips/image/mt7621.mk
@@ -326,7 +326,8 @@ define Device/asus_rt-ax53u
   IMAGE/sysupgrade.bin := sysupgrade-tar | append-metadata
   IMAGE/factory.bin := append-kernel | pad-to $$(KERNEL_SIZE) | append-ubi | \
 	check-size
-  DEVICE_PACKAGES := kmod-mt7915e kmod-usb3 uboot-envtools
+  DEVICE_PACKAGES := kmod-mt7915e kmod-usb3 \
+	uboot-envtools kmod-usb-ledtrig-usbport
 endef
 TARGET_DEVICES += asus_rt-ax53u
 

PS: DFS seems to work properly here.
PS2: kmod-usb-ledtrig-usbport was missing from defconfig.
LE2: v2 patch using the new definitions? used tabs instead of spaces on the power led function line, looks like we need the label too in order for it to work as intended?

1 Like