Question about OpenWrt Pull Request Review Process

[Wolfman_Mac]

Hello all,

I have a question about OpenWrt's process for reviewing PRs opened through the GitHub repository. I opened a PR a three weeks ago to add support for a new device. It took me a few tries to get my commit message formatting to match the structure required by the automated tests, but I addressed those issues quickly and the tests now pass.

Since then, my PR has been sitting in a "Review Required" state.

I completely understand that OpenWrt is held together by a group of dedicated volunteers giving their personal time to the project, so I do not want to come off as impatient, but at the same time, I also want to make sure that the PR does not get overlooked either by accident or because of something that I had neglected to do that I was supposed to have done.

I guess my overall question is: is it normal for a PR for a new device to sit in waiting for a few weeks like this without any review or did I miss a step somewhere along the way that I should have known about but overlooked?

[joelinux60]

Personal experience is that PRs waiting for some weeks is a regular case.

Fulfilling all automated checks is good practice. You may try a chat with claude AI to have it take a look at your PR for some more quality checks.

[Wolfman_Mac]

Great! Thank you! I have actually already cross-checked my work with Claude too. I have also been using the device with my self-built image since opening the PR and I haven't encountered any issues with it so far.

[joelinux60]

Had a look at your Comfast CF-XR186 PR. You may want to add Product Specifications to your commit message. Referring to Vendor web site won't work as commit messages should be self contained. You will find good samples of such commit messages browsing through closed PRs.

[Wolfman_Mac]

Thanks for the feedback! I have added this to my commit message.

It seems that by posting here, I drew attention to the PR and I received more feedback!