The patch just adds two lines to the pppoe kernel module, so you can just build the module and insert it into the running OpenWRT system:
stop ppp (it uses the kernel module when connected): ifdown wan
rmmod pppoe
insmod /root/new_module/pppoe.ko
ifup wan
Just to be sure, you can use the verbose patch (" patch with debug output"), it prints a message when it is loaded (or first used, not sure), just so you can see that the patched module is in use (sometimes insmod loads the original module, from the /lib/modules/ folder, not sure why...).
Also note that you must use the stripped module file, not the one in the build folder! That one might crash your router.
Just compare md5sum of unchanged modules with the installed ones, to find the folder with the "correct" version.
(sorry for this if you are an openwrt build expert, it confused me on my first tries)
PS: the debug version also writes a log when a PADT is recevied, noting the destination address, so you can see of "wrong" packets arrive on your connection. (if they don't then the reason for your problem might be something else)
So far the couple of lost PPPoE sessions I've had since installing the patch in my firmware don't appear to be this issue but just no response to the maximum number of configured pings (was set at 3 pings at 5s intervals; have changed this to 7 pings at 3s intervals to see what happens...).
But I'm glad to see your patch make it into the Linux kernel anyway! Thanks and well done!
As far as I can tell, the issue is present in every kernel since PPPoE support was added until @xerces8's patch was accepted. I would suggest whoever's maintaining the 4.14 LTS kernel has elected not to incorporate it at this time. @xerces8's patch can easily be applied to the 4.14 kernel code (which is what I did) if you need the fix.
It's unlikely you're experiencing this exact issue in the latest snapshots because it was patched.
I am experiencing a different issue with to PPPoE disconnects here. Another user seems to be experiencing something similar here. If you enable debug logging in /etc/ppp/options you can get more info about your disconnects.
I've been struggling with PPPoE disconnections too.
I'm running the last version of Openwrt in an Archer C60 V1 router. I have FTTH service with a TP-Link GPON provided.
It was disconnecting every few hours. The system log shows that Sent PADT and so on...
I've searched and read everything about in the forum.
My router and PPPoE are up now for 2d17h... I'm still observing, but the problem seems to be with SQM QoS.
I disabled all ipv6 services in the router and lan. PPPoE kept disconnecting every now and then.
Then I disabled all the SQM QoS services and connection is up for more than 2 days.
I'll wait 5 days, then I'll put ipv6 back and check how it goes.
SQM was set to pppoe-wan and I also put it to ETH1-WAN and in both situations the connection went down and the log showed that same Sent PADT.
I'm pretty sure is the Link Layer Adaption.
I paid more attention and the default configuration is Link Layer set no none. It was set as ATM.
I have SQM enable again. The pppoe didn't disconnect to apply changes. Let's keep observing.
Mmmh, with SQM on pppoe-wan it will not even see the LCP messages, making it hard (but apparently not impossible) to affect the PPPoE state machine. Are you 100% sure that the link never shows these disconnects without SQM or are they "just" considerably rarer without SQM?
but just no response to the maximum number of configured pings (was set at 3 pings at 5s intervals; have changed this to 7 pings at 3s intervals to see what happens...).