First thing first, if you have something off-topic to say, or you wanna wish me not to succeed, please send me a message. I promise I will not read it because I don't care. Please keep this thread on-topic and clean. Thanks.
I was testing and updated some packages, I will list them with the hashes so some developer can update them easily. And I could build an image and flash it to my router successfully. (Asus RT-AC88U)
How to become a collaborator in GitHub? cause I couldn't open pull request for my suggestion of removing the unnecessary package for 53xx router.
Here are the packages. I will write the name of the package, old version, new version, the hash consecutively. (some packages are already updated in the feeds but not the course code)
Patience, my friend, somebody will take on surveying that bcm usb firmware's actual usage and doing your way. Breaking dozen devices accidentally is not exactly a good start for first contribution.
You become a member of github and then you make a PR and start the review process and if you are lucky it will en up as a commit.
But you can’t do a PR from github webbpage or a windows computer github app.
You must in practical terms use git in a linux terminal to do a PR in github, in order to be able to do the preparation tasks like rebasing etc required to make it a working commit.
You need to fork main repository, then branch , then add your changes in a branch, then add,commit,push and complete pull request in github web interface.
And that also…making a pr was a lot harder than I thought first time.
And then we have the “first check”. Where everyone fails on signature protocol the first time.
And the commit headline must be meaningful and start with the object!
Hi, can you explain a few things to better understand what you are trying to do?
What packages do you plan on removing, are you trying to remove them from the default built image or from the target completely? If you are planning to do the former (update the build script), then sure, you probably won't break other devices. If you are planning to do the latter then I'm not sure anyone will be for it as it will remove functionality that already exists for people using it and will need a really good reason.
In the updates list, some updates are for new revisions, some for new minor versions while some are for new major versions:
you should request updates for the packages individually or for related packages at once: 7z and bash don't have anything to do with each other
for major version updates, you probably need to test for regressions yourself and listing them before making a request
for example, xz is intentionally left at 5.4.6 for now because of the whole Jia Tan situation, and this is one example reason why every non-related package needs to be updated with separate request - to be reviewed individually
Generally I think now is a good time to request updates as I believe main developers will soon decide to branch 24.x since all targets now finally use linux 6.6.
There is a really long thread where the OP discusses a package they wish to remove. They have a test with exactly one device and want to create a PR that eliminates it from an entire family of devices.
A developer who is familiar with the chipsets in question needs to weigh in as an authoritative voice in the matter.
With that said, let's simply keep this thread about providing the OP the information necessary to create a PR and not rehash the previous discussion. Once submitted, it will be in the hands of the devs.
the backdoor was removed in xz 5.6.2, in the feeds it is already 5.6.2 (the router will se this version using okpg update) except in the source code it is still 5.4.6, when compiling 2 versions will be compiled.
You have to read the answers you get. If you don’t want to read instructions and answers you will have a very long way ahead to go to get this working.
I forked, I made the changes, I wrote the pr, then I got a message that I have to be collaborator. There was no way to add without been invited as a collaborator!
Off-topic: but no, it will remove the driver for these 2 specific usb chips, and they can be install later when inserting a USB wifi adapter with these 2 specific usb chips
