Orange pi R1 plus support

ohabu · May 22, 2023, 5:05pm

Well that was unexpected... At least for me!

router -> gateway

40 packets transmitted, 23 packets received, 42% packet loss
round-trip min/avg/max = 0.982/1.077/1.163 ms

ps: gateway is just another dummy router btw

halms · May 22, 2023, 11:52pm

First: I can give another report of everything working well on the LTS with a build of Tianlings latest PR without any additional patches/changes.

And I cannot reproduce the packet loss error on my side.

ohabu · May 23, 2023, 5:43am

It is nice to know. Would you mind sharing kernel log and your builded-firmware please?

ohabu · May 23, 2023, 7:25am

Well...

On new motorcomm driver for rj45 port

1Gbit : Only green LED is active and blinks. On-board WAN-LED works.
100Mbit : Only amber LED is active and blinks. On-board WAN-LED works.
10Mbit : There is no LED activity. on-board WAN-LED works.

Prior to kernel 5.15 Amber light = activity LED and Green LED = link LED, Both of them are always active on any negotiated link speed when link is up.

Can anyone confirm that?

1715173329 · May 23, 2023, 8:03am

github.com

orangepi-xunlong/openwrt/blob/9fde0cfadad6226ec8f2e6748b46f5a98d4a29d7/target/linux/rockchip/patches-5.4/600-Add-yt8531c-support.patch#L443-L452


      
          +int phy_yt8531_led_fixup(struct mii_bus *bus, int addr)
          +{
          +	printk("%s in\n", __func__);
          +
          +	ytphy_mii_wr_ext(bus, addr, 0xa00d, 0x670);
          +	ytphy_mii_wr_ext(bus, addr, 0xa00e, 0x2070);
          +	ytphy_mii_wr_ext(bus, addr, 0xa00f, 0x7e);
          +
          +	return 0;
          +}

github.com

immortalwrt/immortalwrt/blob/master/target/linux/rockchip/patches-5.15/601-net-phy-motorcomm-add-LED-configuration-for-yt8521.patch

--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -1487,6 +1487,13 @@ static int yt8521_config_init(struct phy
 		if (ret < 0)
 			goto err_restore_page;
 	}
+
+	/* LED0: Unused/Off, LED1: Link, LED2: Activity, 8Hz */
+	ytphy_write_ext(phydev, 0xa00b, 0xe004);
+	ytphy_write_ext(phydev, 0xa00c, 0);
+	ytphy_write_ext(phydev, 0xa00d, 0x2600);
+	ytphy_write_ext(phydev, 0xa00e, 0x0070);
+	ytphy_write_ext(phydev, 0xa00f, 0x000a);
 err_restore_page:
 	return phy_restore_page(phydev, old_page, ret);
 }

it's just an ugly hack and cannot be accepted by upstream

ohabu · May 23, 2023, 8:54pm

I guess my problem is related to the way phy-ethernet driver get initialized or some default behavior of network or driver. I did not test it. I will do as soon as i can. Because i have no issues with default generic phy driver on 5.15 with old hacky way(using nanopi-r2s as base).

ohabu · May 24, 2023, 8:38pm

@1715173329 Okay i made it work as it should do. Something is not right with initializing phy on 008-v6.4-arm64-dts-rockchip-Add-Xunlong-OrangePi-R1-Plus-LTS.patch. I just modified the gmac2io node. It works but i do not understand anything with these files. Any suggestion is appreciated. I will have a look when i have time. And of course if you want it, i could share dirty and embrassing gmac2io node .

~~Losses are fixed. But unable to assign or get assigned IP with hotplug event. Router needs to get rebooted to achieve that.~~ motorcomm,auto-sleep-disabled

1715173329 · May 24, 2023, 11:45pm

auto sleep should be disabled, vendor driver also does it

github.com

orangepi-xunlong/openwrt/blob/9fde0cfadad6226ec8f2e6748b46f5a98d4a29d7/target/linux/rockchip/patches-5.4/600-Add-yt8531c-support.patch#L471-L474


      
          +	/* disable auto sleep */
          +	val = ytphy_mii_rd_ext(bus, addr, 0x27);
          +	if (val < 0)
          +	        return val;