Netifd notify_proto (permission denied) glitch

Lynx · February 23, 2024, 3:33pm

The netifd calls in the dispatcher script in ModemManager:

openwrt/packages/blob/4d8bb07b734391d11318cb319548a17273820685/net/modemmanager/files/10-report-down#L35


      
          MODEM_DEVICE=$(modemmanager_get_field "${MODEM_STATUS}" "modem.generic.device")
          [ -n "${MODEM_DEVICE}" ] || exit 2
          
          CFG=$(mm_get_modem_config "${MODEM_DEVICE}")
          [ -n "${CFG}" ] || exit 3
          
          IFUP=$(ifstatus "${CFG}" | jsonfilter -e "@.up")
          
          [ "${IFUP}" = "true" ] && {
          	logger -t "modemmanager" "interface ${CFG} (network device ${INTERFACE}) ${STATE}"
          	proto_init_update $INTERFACE 0
          	proto_send_update $CFG
          }
          
          exit 0

Results in:

Fri Feb 23 15:22:10 2024 daemon.info [2677]: <info>  [modem0] state changed (connected -> disabling)
Fri Feb 23 15:22:10 2024 daemon.info [2677]: <info>  [modem0/bearer45] connection #1 finished: duration 10703s, tx: 56713324 bytes, rx: 3492167535 bytes
Fri Feb 23 15:22:10 2024 user.notice modemmanager: interface wan (network device wwan0) disconnected
Fri Feb 23 15:22:10 2024 daemon.notice netifd: Interface 'wan' has lost the connection
Fri Feb 23 15:22:10 2024 daemon.warn dnsmasq[1]: no servers found in /tmp/resolv.conf.d/resolv.conf.auto, will retry
Fri Feb 23 15:22:10 2024 daemon.notice netifd: Network device 'wwan0' link is down
Fri Feb 23 15:22:10 2024 daemon.info [2677]: <info>  [modem0] 3GPP registration state changed (home -> unknown)
Fri Feb 23 15:22:10 2024 daemon.info [2677]: <info>  [modem0] state changed (disabling -> disabled)
Fri Feb 23 15:22:10 2024 daemon.notice netifd: wan (11819): stopping network
Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): running disconnection (common)
Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): Command failed: ubus call network.interface notify_proto { "action": 0, "link-up": false, "keep": false, "interface": "wan" } (Permission denied)
Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): successfully disconnected all bearers in the modem
Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): Command failed: ubus call network.interface notify_proto { "action": 0, "link-up": false, "keep": false, "interface": "wan" } (Permission denied)
Fri Feb 23 15:22:11 2024 daemon.notice netifd: Interface 'wan' is now down

What's with:

Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): Command failed: ubus call network.interface notify_proto { "action": 0, "link-up": false, "keep": false, "interface": "wan" } (Permission denied)
Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): successfully disconnected all bearers in the modem
Fri Feb 23 15:22:11 2024 daemon.notice netifd: wan (11819): Command failed: ubus call network.interface notify_proto { "action": 0, "link-up": false, "keep": false, "interface": "wan" } (Permission denied)

Lynx · February 23, 2024, 3:41pm

Ah, fixed here:

github.com/openwrt/packages

modemmanager: Fix Permission Denied error

committed 11:46AM - 01 Sep 23 UTC

osedlbauer

+9 -17

The proto_send_update function is sending a notification to netifd during the te…ardown section. However, netifd filters link update notifications executed during teardown, as indicated here: https://git.openwrt.org/?p=project/netifd.git;a=blob;f=proto-shell.c#l515 This was leading to a Permission Denied error due to its behavior, making proto_send_update ineffective during teardown. To address the issue, the proto_send_update function has been removed from the teardown section. This prevents the Permission Denied error while ensuring proper operation during teardown. Additionally, in the 10-report-down helper script, a check has been implemented to determine if the interface is already down. This check is crucial to avoid triggering a Permission Denied error, especially in cases where netifd is already aware of a controlled ifdown operation. Signed-off-by: Oliver Sedlbauer <osedlbauer@tdt.de>

system · March 4, 2024, 3:42pm

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.