Miniupnpd config invalie option problem

When we upgrade miniupnpd version from miniupnpd 2.1.20191006 to miniupnpd 2.3.3.
We can not run miniupnpd normally. it show invalid option file

/usr/sbin/miniupnpd -f /etc/data/miniupnpd/miniupnpd.conf
invalid option in file /etc/data/miniupnpd/miniupnpd.conf line 93 : friendly_name=5G WiFi

the following option at miniupnpd.conf become invalid at new version(2.3.3).
But it is working at old version(2.1.20191006)

any suggestion?

friendly_name
manufacturer_name
manufacturer_url
model_name
model_url

Thanks

Looks like friendly name isn't an option for upnp config file. Refer to https://openwrt.org/docs/guide-user/firewall/upnp/miniupnpd for the optiond

Hello,
the invalid is due to ENABLE_MANUFACTURER_INFO_CONFIGURATION not defined at source code options.c
how to add patch to at source code options.c

static const struct {
	enum upnpconfigoptions id;
	const char * name;
} optionids[] = {
	{ UPNPEXT_IFNAME, "ext_ifname" },
#ifdef ENABLE_IPV6
	{ UPNPEXT_IFNAME6, "ext_ifname6" },
#endif
...

#ifdef ENABLE_MANUFACTURER_INFO_CONFIGURATION
	{ UPNPFRIENDLY_NAME, "friendly_name" },
	{ UPNPMANUFACTURER_NAME, "manufacturer_name" },
	{ UPNPMANUFACTURER_URL, "manufacturer_url" },
	{ UPNPMODEL_NAME, "model_name" },
	{ UPNPMODEL_DESCRIPTION, "model_description" },
	{ UPNPMODEL_URL, "model_url" },
#endif

Thanks

Thanks for the investigation!

What's the file size penalty for enabling this flag?

Do you want to send a PR to the packages repo with the patch?

1 Like