Luci - Changing wifi config results in timeout

pattagghiu · October 19, 2020, 11:01am

Hello,
little "problem" here.
I have a R7800, on r14718
Luci is working with nginx

my "problem": when changing wifi settings through Luci and applying the changes, often it results in a timeout (given that the wifi is not up within the limit) and so changes are reverted back.
I ended up modifying by hand the network config file and restarting the service so it's not a real "problem", but probably a longer timeout could allow changes also via Luci interface..
is this something can be changed manually, as an option? i don't think so.. am i wrong?
thanks

anon50098793 · October 19, 2020, 12:36pm

try extending the XHR/js timeout

pattagghiu · October 19, 2020, 12:42pm

hello,
given that i don't know how to change this
the "timeout" i find is not the red banner XHR timeout error, it's a functional message about the fact that modification weren't applied within 30 seconds so they are reverted.
Is it the same?

anon50098793 · October 19, 2020, 12:46pm

ok, the network settings were not applied timeout... is there no 'apply unchecked'?

pattagghiu · October 19, 2020, 12:59pm

yes, there is. but it's just a workaround in this case, isn't it?

anon50098793 · October 19, 2020, 1:02pm

semantics... if it works, whats the difference?

pattagghiu · October 19, 2020, 1:05pm

ahahaha i like your way of seeing things
to me, if this is the solution, the timer for the application of settings is totally useless.
and i could also apply settings from the CLI, (as i did)..
as i said in the opening post, this is not a "real" problem, but something linked to the usability of Luci, there are other ways to apply settings, but is the timeout we have today good in any situation?
was just a suggestion to improve luci

anon50098793 · October 19, 2020, 1:12pm

it's a good suggestion... and becomes more relevant the more frequently users encounter issues with it...

I never even knew it could be trigger by wifi

hnyman · October 19, 2020, 1:36pm

Why not? In practice it concerns all config changes. Also a wifi config change could accidentally soft-brick a device, and this tries to prevent that.

You are wrong. There is a dedicated config item for that in /etc/config/luci
Current default is 90 seconds (but if you have an old /etc/config/luci, it might be only 30 seconds in your system).

github.com

openwrt/luci/blob/master/modules/luci-base/root/etc/config/luci#L28


      
          config internal sauth
          	option sessionpath "/tmp/luci-sessions"
          	option sessiontime 3600
          	
          config internal ccache
          	option enable 1
          		
          config internal themes
          
          config internal apply
          	option rollback 90
          	option holdoff 4
          	option timeout 5
          	option display 1.5

pattagghiu · October 19, 2020, 1:40pm

well, /etc/config/luci is definitely a file that is part of the backup of the system, for sure mine is as old as hell..
damn, you know really everything

thanks a lot, i'm gonna try editing it

Edit: i have so old config files that i still have luci and luci-opkg splitted
Is there a way i can update those files if not manually?
I assume i can't cherry pick only come files from /etc/config for my backup..

hnyman · October 19, 2020, 2:37pm

The current default /etc/config/luci is in the flashed firmware, visible as /rom...

/rom/etc/config/luci

You can simply copy it.

Ps. pretty much all default configs are there.
network and system are the two exceptions that are created on the fly if they are missing.

hnyman · October 19, 2020, 2:45pm

Looks like @jow prolonged the rollback timeout default to 90 seconds in February, but he did not change the built-in fallback defaults that get applied if there is no config item at all in /etc/config/luci. Those (like you) still get the short 30 seconds as the rollback timeout

I will probably issue a PR to change also those fallback defaults, so that people upgrading with really old systems do get the more practical 90 seconds timeout for rollback. I guess that not everybody regularly re-creates their config or compares it to the current defaults

Using ancient config may degrade the user experience, as you have now noticed...

pattagghiu · October 19, 2020, 3:06pm

yes, but in this case it wasn't intended
i mean, if i could cherry pick files in /etc/config for backup, i would have not selected luci. I'll fix my backup manually.
In any case, do you also know if i can disable the default checked checkbox for "keep settings" when upgrading firmware?

hnyman · October 19, 2020, 3:10pm

Not really. The backup files are defined, but not "the files to be excluded".

Ps.

github.com/openwrt/luci

Set the fallback default of rollback timeout to 90s

openwrt:master ← hnyman:rollback

opened 03:06PM - 19 Oct 20 UTC

hnyman

+4 -4

cc @jow- @feckert luci-base & luci-app-dockerman: set the fallback default o…f rollback timeout to 90s Set the fallback value of the config change rollback timeout to 90 seconds to match the change in /etc/config/luci by commit 81cf99a50. That commit changed the default value in the config file, but did not change the underlying fallback values that do get applied when there is no proper config item in etc/config/luci. Users sysupgrading from old systems may have carried an ancient /etc/config/luci (without rollback config) with them, so this change should help them to see the intended user experience of 90 seconds instead of 30 seconds that may be too short e.g. for wifi changes. Related to forum discussion at https://forum.openwrt.org/t/luci-changing-wifi-config-results-in-timeout/77104/9 Ps. The luci-base part should also be backported to 19.07.

pattagghiu · October 19, 2020, 3:13pm

i've just understood that this is true only if i use a clean build.
I build my own image (based on yours) so i have the /files folder with my config files and so on..
thanks anyway

system · October 29, 2020, 3:13pm

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.