LuCI APP: luci-app-sms-manager (SMS / USSD / AT commands via ModemManager)

IceG · January 25, 2026, 11:58am

Hi, I created next small LuCI app.

Simple user interface to handle SMS / USSD / AT commands via ModemManager application.

I am adding it again after corrections.

https://github.com/4IceG/luci-app-sms-manager/releases

The latest version always on

brada4 · January 25, 2026, 1:32pm

Is it vibe coded?

github.com/4IceG/luci-app-sms-manager

luci-app-sms-manager/root/sbin/new_cron_sms_manager.sh

479afab98


      
          
          if [ "x$SLED" = "x1" ]; then
          	if ! grep -q "sms_manager" /etc/crontabs/root; then
          		PTR=$(uci -q get sms_manager.@sms_manager[0].prestart)
          		echo "1 */$PTR * * *  /etc/init.d/sms_manager enable && /etc/init.d/sms_manager restart" >> /etc/crontabs/root
          		/etc/init.d/cron restart
          	fi
          	exit 0
          fi
          
          if [ "x$SLED" = "x0" ]; then
          	if grep -q "sms_manager" /etc/crontabs/root; then
          		grep -v "sms_manager" /etc/crontabs/root > /tmp/new_cron
          		mv /tmp/new_cron /etc/crontabs/root
          		/etc/init.d/cron restart
          	fi
          	exit 0
          fi
          
          exit 0

IceG · January 25, 2026, 2:01pm

@brada4 If you find a bug, report it on GitHub and it will be fixed.
You probably looked through the entire code, not just this script .

brada4 · January 25, 2026, 2:59pm

Look where? "unsafe temporary file handling"

IceG · January 25, 2026, 3:13pm

Post deleted, it referred to old, deleted code.

brada4 · January 25, 2026, 3:19pm

Reality check round number one:
/tmp/new_cron is a symlink to
A /dev/urandom
B/ /etc/shadow
C/ /sbin/init

IceG · January 25, 2026, 3:43pm

Okay, I'm removing the package. I've been using it for years. I didn't know it such a huge security risk to users. Thanks for the info and for saving everyone.

brada4 · January 25, 2026, 6:35pm

I dont mean to sabotage it, just that whole crontab block is like made in one minute (next - crontab spool format is not portable, you have to use command line to feed crontabs via commands) and too many bugs concentrate in few lines.

IceG · January 25, 2026, 9:36pm

This code worked flawlessly for several years, but OK.
I'm not good at programming, so I'd rather remove it (before I blow up users routers).
OpenWrt users will survive without my package.

brada4 · January 25, 2026, 10:23pm

javascript is rather elegand....

IceG · January 27, 2026, 7:44am

OK, adding again after changes to the code.

brada4 · January 27, 2026, 8:02am

Looks much better now. All suspect fragments addressed.