Lets talk about firewall4 (default nftables firewall)

systemcrash · October 9, 2025, 8:52pm

dave14305:

log without prefix is unexpected in the parser, and fw4 will always emit a prefix (default to rule name), but it would be more flexible if prefix was optional in the parser.
	case 'log':
			return E('span', {
				'class': 'ifacebadge'
			}, action_translations.log.format(spec.prefix));

We could have:


		case 'log':
			return E('span', {
				'class': 'ifacebadge'
			}, action_translations.log.format(spec?.prefix || '-'));

which fills:

'log': _('Log event "<strong>%h</strong>…"', 'nft log action'),

so it’d be : Log event “-”

But I’m not sure why we’re touching log here, though, since it’s ‘unexpected’. I guess you guys know better

That puts the counter after the rule, and fixes the log spec.prefix.

=====

You assert that you’re removing an unused kernel module - that it’s unused… until fib is used in a user nft.