Ksmbd (Samba3/4 alternative, ex cifsd/smbd) package support thread

oneil4 · 2021-08-26T03:44:15.034Z

i have try

image1920×1080 179 KB

and allow ip 10.0.0.1 on peer, after reboot, don't work again

oneil4 · 2021-08-26T03:55:21.513Z

manywrt:

Thanks. I tried what you quoted (except as conformed to my config file's format, which looks like option path '/mnt/dump') but did not work. Adding the force user and force group lines also had the curious effect of wiping out LuCI's ksmbd page. Deleting those lines restored the page contents.

oh sorry ( i'm new user )

look the video : https://youtu.be/u_ReoGE4Jb8?t=1670

maybe other members more pro of me have solution for you

erdoukki · 2021-08-31T16:11:08.711Z

Andy2244:

PS: For me adding WG to the lan bridge works fine for smb share access. Maybe your routing options in the client are wrong?

whoo... adding a bridge between WG and LAN may be very risky !
You'll have IP crash because they have both IP in different subnets !!!
Do not do that...

shevalier · 2021-09-03T18:34:06.138Z

hi, I am migrated from samba4 to ksmbd on release version 21.02(Ksmbd: 3.3.9 Kmod: 3.3.9).
and got the spam in kernel log, when open any file

[32338.689393] ksmbd: ndr_decode_dos_attr:181: v107 version is not supported
.
.
.
[32891.243266] ksmbd: ndr_decode_dos_attr:181: v114 version is not supported

neheb · 2021-09-04T23:28:26.121Z

code tests for version 3 or 4. Sounds like some bug.

pesa1234 · 2021-11-26T15:36:37.207Z

Dear all,
I would like to share with you my solved issue with ksmbd and automount procedure.

in /etc/hotplug.d/block/
I have two files 10-mount and 60-ksmbd

10-mount content

#!/bin/sh

blkdev=`dirname $DEVPATH`
device=`basename $DEVPATH`
hdorsd=`echo "$device" | grep -E '[sh]d*|mmcblk0*' `

logger "+++++++blkdev: $blkdev -device: $device -hdorsd: $hdorsd"
sleep 3
[ -n "$hdorsd" ] && {
    case "$ACTION" in
        add)
            s=`/usr/sbin/blkid /dev/$device|sed -n 's/.* TYPE="\([^"]*\)".*/\1/p'`
            label=`/usr/sbin/blkid -d /dev/$device|sed -n 's/.*LABEL="\([^"]*\)".*/\1/p'`
            
            #logger "+++Label: $label -Filesystem: $s"
            [ -z "$label" -o "$s" = "vfat" ] && label=$device

            if [ "$s" != 'f2fs' -a "$s" != 'vfat' -a "$s" != 'ntfs' -a "$s" != 'ext2' -a "$s" != "ext3" -a "$s" != "ext4" -a "$s" != "exfat" ];then
            return;
            fi
            mkdir -p "/mnt/$label"
			#logger -t hotplug "+++ New folder in /mnt/ $label"
			if [ "$s" = 'vfat' -o "$s" = 'exfat' ];then
                mount -t $s -o utf8,rw,async,noatime,fmask=0000,dmask=0000 /dev/$device "/mnt/$label"
            fi

            if [ "$s" = 'ntfs' ];then
                mount -t ntfs-3g -o utf8 /dev/$device "/mnt/$label"
            fi

            if [ "$s" = 'ext2' -o "$s" = 'ext3' -o "$s" = 'ext4' ];then
                mount -t ext4 -o rw,async,noatime /dev/$device "/mnt/$label"
                chmod 777 -R "/mnt/$label"
                chown root:root "/mnt/$label"
            fi
            if [ "$s" = 'f2fs' ];then
                mount -t f2fs -o rw,async,noatime /dev/$device "/mnt/$label"
                chmod -R 777 "/mnt/$label"
                chown root:root "/mnt/$label"
                #logger -t hotplug "Should be an f2fs filesystem"
            fi
			logger -t hotplug "+++ mounted filesystem: $s -label: $label"
			;;

        remove)
		
		folder="$(grep /dev/$device /etc/mtab |awk '{print $2}')"
		umount "$folder"
		rmdir "$folder"
            
            logger -t hotplug "+++ Removed: ${folder}"
            
            ;;
    esac
    
}

This file with blkid automount the device.

and this is 60-ksmbd

#!/bin/sh

blkdev=`dirname $DEVPATH`
device=`basename $DEVPATH`
hdorsd=`echo "$device" | grep -E '[sh]d*|mmcblk0*' `
label=`/usr/sbin/blkid -d /dev/$device|sed -n 's/.*LABEL="\([^"]*\)".*/\1/p'`
filesys=`/usr/sbin/blkid /dev/$device|sed -n 's/.* TYPE="\([^"]*\)".*/\1/p'`
mmc_share_exist=0
mylabel="volume(sda1)"

#logger "+++1-$blkdev 2-$device 3-$hdorsd 4-$label 5-$filesys"

#vfat use ANSI label name
[ -z "$label" -o "$filesys" = "vfat" ] && label=$device

[ -n "$hdorsd" ] && {
	case "$ACTION" in
	add)
		[ -z "$filesys" -o "$filesys" = "swap" ] && exit 0 #must have file system and not swap
		[ "$label" = "rootfs" -o "$label" = "rootfs_data" ] && exit 0  #s1300 emmc rootfs and rootfs_data not setup as samba share
		#first loop the shares. If there is any duplicated entry, delte it first.
		i=$(uci show ksmbd|awk 'NF{p=$0}END{print p}'|sed -e "s/^.*\[\\(.*\)\].*$/\1/")
		while [ "$i" -ge 0 ]
		do
			sharepath=$(uci get ksmbd.@share[$i].path)
			[ "$sharepath" = "/mnt/$label" ] && {
				uci delete ksmbd.@share[$i]
			}
			[ "$sharepath" = "/data" ] && mmc_share_exist=1
			i=$(( i-1 ))
		done

		mmcblk0=`echo "$device" |grep 'mmcblk0'`
		[ -n "$mmcblk0" -a "$mmc_share_exist" = "1" ] && exit 0
		uci add ksmbd share

		if [ -n "$mmcblk0" ]; then
			uci set ksmbd.@share[-1].name="data"
			uci set ksmbd.@share[-1].path="/data"
		else
			uci set ksmbd.@share[-1].path="/mnt/$label"
			uci set ksmbd.@share[-1].name="$mylabel"
		fi

		uci set ksmbd.@share[-1].read_only=no
		uci set ksmbd.@share[-1].guest_ok=yes
		uci set ksmbd.@share[-1].create_mask=0777
		uci set ksmbd.@share[-1].dir_mask=0777
		uci set ksmbd.@share[-1].inherit_owner=yes
		uci set ksmbd.@share[-1].force_root=1
		uci commit ksmbd
		/etc/init.d/ksmbd restart
		logger -t hotplug "+++New share available: ${label}"
		;;

	remove)
		i=$(uci show ksmbd|awk 'NF{p=$0}END{print p}'|sed -e "s/^.*\[\\(.*\)\].*$/\1/")
		while [ "$i" -ge 0 ]
		do
			sharepath=$(uci get ksmbd.@share[$i].path)
			d=$(uci get ksmbd.@share[$i].name)
			if [ ! -e "$sharepath" -o "$d" = "$label" ]
			then
				uci delete ksmbd.@share[$i]
				logger -t hotplug "+++Removed share: ${label}"
			fi

			i=$((i-1))
		done
		uci commit ksmbd
		/etc/init.d/ksmbd restart
		;;
	esac
}

This file create a share...

This procedure works perfectly if it is an hotplug, but on boot or restart with flashdisk connected ksmd won't start.
So, if I run

netstat -an | grep 445

I don't see the service active.
To solve the issue on startup I run this script to restart the ksmbd service in case I need it...

#!/bin/sh

sleep 7 #just to be sure....
var=`netstat -an | grep 445 | grep tcp`

if [ -z "$var" ]
then
      /etc/init.d/ksmbd restart
	  logger "+++++++ restarted service not active ++++++"
else
      logger "+++++ ksmb is running ++++++"
fi

exit 0

I hope that this can help someone else... or if I do something wrong, suggestion are welcome...

THANKS!!!

EDIT: Solved by add an user on ksmbd

gvalkov · 2021-11-28T17:00:43.208Z

@danitool sleep doesn't work for me, stop_service however works and seems like a good solution, since internally it calls kill_server if needed, then performs cleanup. I'll try to make a PR.

# net/ksmbd-tools/files/ksmbd.init
-- kill_server
++ [ -e /sys/module/ksmbd ] && stop_service

gvalkov · 2021-11-28T17:42:29.018Z

@neheb @Andy2244 @danitool

github.com/openwrt/packages

ksmbd-tools: Fix ksmbd service is semi-killed at system startup

openwrt:master ← httpstorm:ksmbd-tools.2021-11-28

opened 05:40PM - 28 Nov 21 UTC

httpstorm

+2 -2

The configuration for the ksmbd service is auto-generated when the OpenWRT confi…guration changes, and also during startup, hence ksmbd.init has to reload the kernel module. It does that by calling kill_server, which does not perform cleanup. This results in ksmbd being killed but not restarted properly during boot. This patch resolves the issue by using stop_service, which performs proper cleanup. https://forum.openwrt.org/t/ksmbd-samba3-4-alternative-ex-cifsd-smbd-package-support-thread/51695/68 Maintainer: @Andy2244 Compile tested: (x86_x64, OpenWrt version r18176) Run tested: (x86_x64, OpenWrt version r18176, tests done: startup, change config) @neheb

pesa1234 · 2021-11-29T09:06:09.234Z

Hi, with this patch my ksmbd won't start anymore

One more thing...
If I try to create a new excel document on shared folder (guest access) from win client ( right click -> new excel document )
I have these messages

Sun Oct 24 09:06:29 2021 kern.err kernel: [  307.130959] ksmbd: parse_sec_desc:814: parse_sec_desc: Error -22 mapping Owner SID to uid
Sun Oct 24 09:06:29 2021 kern.err kernel: [  307.139603] ksmbd: parse_sec_desc:829: parse_sec_desc: Error -22 mapping Group SID to gid
Sun Oct 24 09:06:29 2021 kern.err kernel: [  307.148112] ksmbd: parse_dacl:479: parse_dacl: Error -22 mapping Owner SID to uid
Sun Oct 24 09:06:29 2021 kern.err kernel: [  307.155934] ksmbd: parse_dacl:479: parse_dacl: Error -22 mapping Owner SID to uid

Any help will be appreciated

gvalkov · 2021-11-29T11:59:04.539Z

Hi @pesa1234 patches are applied and valid at a certain point in time. I tested the changes on the latest master and everything seems to work fine. Older versions of ksmbd-tools might have different startup requirements. If you provide information about your environment, I might be able to perform additional research and give you feedback. What version of OpenWRT and ksmbd-tools are you using? Is it official release of custom build? You might also compile the latest master provide feedback if it works for you.
The patch is now merged.

fda · 2021-11-29T14:33:34.489Z

Great, https://github.com/openwrt/packages/commit/4af04cdc05af1e78dab310550fae5bae21d51c8c fixes the "wsdd2: samba36/4 or ksmbd is not running, can't start wsdd2!" error on startup! ksmbd and wsdd2 now finally working out of the box. Thanks!

gvalkov · 2021-11-29T15:05:19.754Z

@fda I'm glad it worked for you!

pesa1234 · 2021-11-29T15:31:03.563Z

Hi, thanks for your answer.
I'm openwrt 21.02.1

ksmbd-server	3.4.2-1
kmod-fs-ksmbd	5.4.154+3.3.9-1
luci-app-ksmbd	git-21.295.66827-c592d0a

If I try to modify the /etc/init.d/ksmbd as the patch still don't start. Please have a look at post Ksmbd (Samba3/4 alternative, ex cifsd/smbd) package support thread - #137 by pesa1234

Thanks

gvalkov · 2021-11-29T16:27:32.682Z

@pesa1234 Did you make the correct changes? I just tested the following steps, and everything works fine.

Download the official OpenWRT release for 21.02.1 x64:
https://firmware-selector.openwrt.org/?version=21.02.1&target=x86%2F64&id=generic
Install luci-app-ksmbd, ksmbd-utils
Create user ksmbd.adduser -a USER
Add a network share.
Edit /etc/init.d/ksmbd https://pastebin.com/idC4hZAr
reboot
net use z: \\192.168.1.1\test /user:USER
success

pesa1234 · 2021-11-29T16:54:56.250Z

I'll try and I let you know, is it possible that I have issue because I use only guest access?

THANKS

gvalkov · 2021-11-29T17:06:08.128Z

@pesa1234 Port 445 should be open regardless of the account type, unless ksmbd requires at least one user to be created before it can start. Tip: If you create a user with the same name and password as your client, it will login automatically without a password prompt. This is the default behaviour of Windows, and I think macOS too. Not sure about Linux.

pesa1234 · 2021-11-30T10:18:03.777Z

Now with user added and

# net/ksmbd-tools/files/ksmbd.init
-- kill_server
++ [ -e /sys/module/ksmbd ] && stop_service

all my shared folder works perfectly.

On samba it works also without add an user, this difference give me issues. Sorry

Now, the only issue is:

Tue Nov 30 10:24:31 2021 kern.err kernel: [  939.193231] ksmbd: parse_sec_desc:814: parse_sec_desc: Error -22 mapping Owner SID to uid
Tue Nov 30 10:24:31 2021 kern.err kernel: [  939.201765] ksmbd: parse_sec_desc:829: parse_sec_desc: Error -22 mapping Group SID to gid
Tue Nov 30 10:24:31 2021 kern.err kernel: [  939.210269] ksmbd: parse_dacl:479: parse_dacl: Error -22 mapping Owner SID to uid
Tue Nov 30 10:24:31 2021 kern.err kernel: [  939.218073] ksmbd: parse_dacl:479: parse_dacl: Error -22 mapping Owner SID to uid

This happen if I allow guest on the share and they try to create a new excel document

gvalkov · 2021-12-01T18:15:19.157Z

@pesa1234 A good place to ask about this error: https://github.com/cifsd-team/ksmbd/issues
I do not see it, with a registered user.

pesa1234 · 2021-12-02T00:28:19.374Z

Thank you so much! I'll go there to post my issue.

Do you know why windows XP users can't log on on my ksmbd share? What I made wrong now?

gvalkov · 2021-12-02T01:23:09.323Z

@pesa1234 Obviously you don't care about security, so try to enable Allow legacy (insecure) protocols/authentication. I could not get 2003 R2 x64 to connect either. My guess would be lack of SHA2 and modern SMB protocols.