Init script for openwisp-config

Gorey · October 16, 2024, 12:57pm

openwisp-config 1.0.1-2 is fine.

# grep PROG= /etc/init.d/openwisp_config
PROG="/usr/sbin/openwisp_config"
# ll /usr/sbin/openwisp_config
-rwxr-xr-x    1 root     root         23714 Sep 22  2022 /usr/sbin/openwisp_config

But with 1.1.0-1, PROG is instead /usr/sbin/openwisp-config which doesn't exist!

root@OpenWrt:~# opkg install openwisp-config
Installing openwisp-config (1.1.0-1) to root...
...<all the dependencies>...
Configuring openwisp-config.
openwisp: OpenWISP config agent started
root@OpenWrt:~# grep PROG= /etc/init.d/openwisp_config
PROG="/usr/sbin/openwisp-config"
root@OpenWrt:~# ll /usr/sbin/openwisp-config
ls: /usr/sbin/openwisp-config: No such file or directory
root@OpenWrt:~# logread | grep openwisp
Wed Oct 16 12:55:26 2024 daemon.info openwisp: OpenWISP config agent started
Wed Oct 16 12:55:51 2024 daemon.info procd: Instance openwisp_config::instance1 s in a crash loop 6 crashes, 0 seconds since last crash

Gorey · October 18, 2024, 4:13pm

How does one report a packaging bug with an OpenWRT package?

brada4 · October 18, 2024, 5:23pm

tag maintainer, that not responding add recent regular commiters

Gorey · October 21, 2024, 11:53am

Thanks, looks like somebody beat me to it!

github.com/openwrt/packages

openwisp-config: instance1 s in a crash loop x

opened 01:56PM - 19 Oct 24 UTC

diepeterpan

Maintainer: @pandafy, @nemesifier **Environment:** mediatek/filogic, Cudy WR…3000 v1, OpenWrt 23.05.5 r24106-10cc5fcd00 But likely impacting all users of package **openwisp-config version 1.1.0-1** **Description:** Upgraded the package of openwisp-config to version 1.1.0-1 in OpenWrt 23.05.5. I couldn't connect to the controller anymore. In logs this message appears (and controller doesn't see the client): `Instance openwisp_config::instance1 s in a crash loop 6` **Also see:** [https://github.com/openwisp/openwisp-config/issues/223](https://github.com/openwisp/openwisp-config/issues/223) Hunting down the bug I discovered that /etc/init.d/openwisp_config wants to execute PROG="/usr/sbin/openwisp-config" but it does not exists, it is called PROG="/usr/sbin/openwisp_config" according to the changelog there were changes re: the - 'hyphen' vs _ 'underscore' ; maybe it just gets packaged incorrectly? Once I edited /etc/init.d/openwisp_config and changed the - 'hyphen' to a _ 'underscore' in PROG= the new agent also started to work. Easier than rolling back. Looks like the problem is in the OpenWrt Makefile - https://github.com/openwrt/packages/blob/dd2e7105e6f0abf9b72155e2b26298ed19a92ab9/admin/openwisp-config/Makefile which needs to be updated to produce hyphens instead of underscores. ``` $(INSTALL_BIN) \ $(PKG_BUILD_DIR)/openwisp-config/files/openwisp.agent \ $(1)/usr/sbin/openwisp_config $(INSTALL_BIN) \ $(PKG_BUILD_DIR)/openwisp-config/files/openwisp.init \ $(1)/etc/init.d/openwisp_config ``` should maybe be ``` $(INSTALL_BIN) \ $(PKG_BUILD_DIR)/openwisp-config/files/openwisp.agent \ $(1)/usr/sbin/openwisp-config $(INSTALL_BIN) \ $(PKG_BUILD_DIR)/openwisp-config/files/openwisp.init \ $(1)/etc/init.d/openwisp-config ```

Gorey · October 21, 2024, 12:07pm

My temporary solution until this bug is fixed is:

ln -s /usr/sbin/openwisp_config /usr/sbin/openwisp-config

nemesis · October 21, 2024, 11:53pm

Going to send a fix tomorrow. In the meantime use one of the builds from downloads.openwisp.io.

nemesis · October 22, 2024, 7:14pm

Fixes for the new version of the packages are ready for review:

Thanks for bringing this up!