How to run a simple script

[kenuser]

Hi,
I would like to add a script to crontab. Ping a host and if not reply restart the local service.

> #!/bin/sh
> # Configuration
> ZEROTIER_PEER="10.0.0.3"
> PING_TIMEOUT=3
> # Check ZEROTIER peer reachability
> ping -c 2 -W $PING_TIMEOUT $ZEROTIER_PEER > /dev/null
> if [ $? -ne 0 ]; then
>     # ZEROTIER peer unreachable, restart Zerotier
>     /etc/init.d/zerotier restart
>     # Log the restart event (optional)
>     logger -t "zerotier_restart.sh" "ZEROTIER peer unreachable, restarting Zerotier"
> fi

I created this file zerotier_restart.sh and copy it to /etc/zerotier/
then I did: chmod +x /etc/zerotier/zerotier_restart.sh

but the output is:

root@openwrt:/etc/zerotier# ./zerotier_restart.sh
-ash: ./zerotier_restart.sh: not found

where am I going wrong?

[frollic]

Are those > on every line part of the script, or is it just the way you pasted it ?

[kenuser]

just pasted from notepad++

[frollic]

You're not answering the question...

Does the file on your Openwrt device contain those > on every line ?

[kenuser]

do not contain >
this is the script in .sh file:

#!/bin/sh
# Configuration
ZEROTIER_PEER="10.0.0.3"
PING_TIMEOUT=3
# Check ZEROTIER peer reachability
ping -c 2 -W $PING_TIMEOUT $ZEROTIER_PEER > /dev/null
if [ $? -ne 0 ]; then
    # ZEROTIER peer unreachable, restart Zerotier
    /etc/init.d/zerotier restart
    # Log the restart event (optional)
    logger -t "zerotier_restart.sh" "ZEROTIER peer unreachable, restarting Zerotier"
fi

[pavelgl]

@kenuser

-ash: ./zerotier_restart.sh: not found

Most likely, the file was created under Windows.
Try to fix it this way:

sed -i -e "s/\r//g" /etc/zerotier/zerotier_restart.sh

[kenuser]

@pavelgl

sed -i -e "s/\r//g" /etc/zerotier/zerotier_restart.sh

Thank you !!

[frollic]

@pavelgl

Try to fix it this way:

Doesn't dos2unix exist on Openwrt ?

[kenuser]

uhhmmmm..

I checked the script is running correctly, but I scheduled this task to system crontab:

#
*/5 * * * * /etc/zerotier/zerotier_restart.sh
#

the log shows error:

root@openwrt:~# logread -e cron
Sat May 24 10:07:20 2025 cron.err crond[18449]: crond (busybox 1.35.0) started, log level 5
Sat May 24 10:10:00 2025 cron.err crond[18449]: USER root pid 18645 cmd /etc/zerotier/zerotier_restart.sh
Sat May 24 10:15:00 2025 cron.err crond[18449]: USER root pid 19038 cmd /etc/zerotier/zerotier_restart.sh

[frollic]

Pretty sure the cron.err is normal, even if it executed correctly.

[kenuser]

You are right, log show error but is executed

[pavelgl]

@frollic

Doesn't dos2unix exist on Openwrt ?

If you think it's worth installing it just to convert one file, yes, why not

@kenuser

Sat May 24 10:10:00 2025 cron.err crond[18449]: USER root pid 18645 cmd /etc/zerotier/zerotier_restart.sh

You can get rid of those messages that fill up the logs.

uci set system.@system[0].cronloglevel="9"
uci commit system
/etc/init.d/cron restart