I made a PR to openwrt/package repo https://github.com/openwrt/packages/pull/27831 , got LGTM from that package’s maintainer (but he’s not a maintainer for entire repo) few weeks ago, then cricket. I think I need to ping someone to it’s ready to merge, but not sure how.
I would take a look at who is actively merging in the packages git history, and @mention them asking for review.
2 Likes
Or prepare to celebrate your PRs birthdays....
1 Like
My read is that you got a LGTM... but you've then stacked on another bunch of commits.
So that resets the entire review situation. You should not have added more onto it once the first review was done, save them for another PR.
Quite a few of your commits will also be contentious, and don't relate to the title of your PR.
Are these necessary for the stated goal of your PR?
- uacme: update to 1.8.0
- moved location of dns api config file for less clutter on main acme state dir
They don't seem related to the title of uacme: use acme-common and make it able to use acme.sh dns apis.
2 Likes
acme-common itself was updated meanwhile, and there was a bug in 1.7.6 that panics in musl build when an option that acme-common was added support of
dns api was just I though it was too big in disk space so moved it to separate package, but rollbacking it will edit shared part again so too late to rollback now.