How can we make the lantiq xrx200 devices faster

francisuk1989 · June 28, 2021, 4:51pm

When testing the DSA driver on the BT HH5A did you see any CPU going as far as say 50%

olek210 · June 28, 2021, 5:25pm

Only the first core(VPE) deals with the processing of packets and interrupts from the network card. The load during testing is most often less than 50%.

You can also try Threaded NAPI, but it is slower. It seems that context switching between threads (VPE) costs a lot.

stonerl · June 30, 2021, 5:27pm

Will these changes be part of the 21.02 release?

slh · June 30, 2021, 7:27pm

No, it's way too late for that - there'll always be a next release.

gruzija · July 3, 2021, 3:16pm

http://lists.openwrt.org/pipermail/openwrt-devel/2021-June/035711.html

Fingers crossed

olek210 · July 4, 2021, 3:02pm

Some IPv6 Routing benchmark (LAN<->WAN) on the BT HH5A with enabled software offloading:

Test         1W                    8W             Increase
WAN->LAN   330 Mb/s              490 Mb/s           +48 %
LAN->WAN   338 Mb/s              590 Mb/s           +75 %

Burst length PR.

PaulRowland · July 9, 2021, 1:14pm

@olek210

This works for me except where a 100M wired device is connected to the bthh5a switch, the router issues an ip but the linux laptop never connects. Works fine with 1G wired etherne, wifi, usb WWAN etc. I cannot test xDSL.

Thank you for your excellent work on speeding up the xrx200!

EDIT: My bad, a new ethernet cable sorted out the 100M wired link! Superb work. Thank you. I am building with kernel 5.10.46.

DermotMcDonnell · July 11, 2021, 11:41am

Hi Aleksander,

I get wan using a huawei modem that presents as an NCM device. Applying your patches resulted in my LAN --> WAN speed doubling!!!

I greatly appreciate your excellent contribution! Thank you very much.

Mine setup is also BTHH5a with kernel 5.10.46.

olek210 · July 11, 2021, 1:03pm

Hi,
@PaulRowland @DermotMcDonnell and everyone interested in this PR
Thanks for the tests. It would be great if you could add it in the form of a
Tested-by: your name <your@email> # tested on device/model.

Best regards,
Aleksander

DermotMcDonnell · July 12, 2021, 1:29pm

Hi Aleksander,

I am new to testing pull requests. Should I set up an account on github and comment on your pull request there?

Thanks again!!

PaulRowland · July 12, 2021, 5:31pm

I did git pull this morning and built with your latest patches, flashed it and now lan ports 1->4 do not connect. The Red WAN port on the bthh5a works fine. This is what I see in syslog:

Mon Jul 12 11:55:35 2021 kern.info kernel: [   95.408869] br-lan: port 4(lan4) entered disabled state
Mon Jul 12 11:55:35 2021 daemon.notice netifd: Network device 'lan4' link is down
Mon Jul 12 11:55:39 2021 kern.info kernel: [   98.525424] gswip 1e108000.switch lan4: Link is Up - 10Mbps/Half - flow control off
Mon Jul 12 11:55:39 2021 kern.info kernel: [   98.531716] br-lan: port 4(lan4) entered blocking state
Mon Jul 12 11:55:39 2021 kern.info kernel: [   98.537244] br-lan: port 4(lan4) entered forwarding state
Mon Jul 12 11:55:39 2021 daemon.notice netifd: Network device 'lan4' link is up
Mon Jul 12 11:56:29 2021 daemon.info dnsmasq-dhcp[4211]: DHCPREQUEST(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:29 2021 daemon.info dnsmasq-dhcp[4211]: DHCPACK(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx pr-pc
Mon Jul 12 11:56:31 2021 daemon.info dnsmasq-dhcp[4211]: DHCPDISCOVER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:31 2021 daemon.info dnsmasq-dhcp[4211]: DHCPOFFER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:33 2021 daemon.info dnsmasq-dhcp[4211]: DHCPDISCOVER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:33 2021 daemon.info dnsmasq-dhcp[4211]: DHCPOFFER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:38 2021 daemon.info dnsmasq-dhcp[4211]: DHCPDISCOVER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:38 2021 daemon.info dnsmasq-dhcp[4211]: DHCPOFFER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:47 2021 daemon.info dnsmasq-dhcp[4211]: DHCPDISCOVER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:56:47 2021 daemon.info dnsmasq-dhcp[4211]: DHCPOFFER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:57:03 2021 daemon.info dnsmasq-dhcp[4211]: DHCPDISCOVER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx
Mon Jul 12 11:57:03 2021 daemon.info dnsmasq-dhcp[4211]: DHCPOFFER(br-lan) 192.168.1.237 xx:xx:xx:xx:xx:xx

I tried 100M and 1G devices also, same result in syslog.

ndilieto · August 7, 2021, 3:48pm

Is this the ethernet HW acceleration driver source code for Lantiq?

github.com

brunompena/dwr-966/blob/master/target/linux/lantiq/files/drivers/net/lantiq_ppa/ppa_api/ppa_api_sw_accel_module.c

/*******************************************************************************
**
** FILE NAME    : ppa_api_sw_accel_module.c
** PROJECT      : PPA
** MODULES      : PPA API (Module Wrapper for Software Acceleration)
**
** DATE         : 13 Mar 2014
** AUTHOR       : Lantiq
** DESCRIPTION  : WRAPPER FUNCTIONS TO MAKE SOFTWARE ACCELERATION A LODABLE 
**   		  KERNEL MODULE. ALL CODE AVAILABLE IN SOFTWARE ACCELERATION 
**		  MODULE IS LANTIQ PROPRIETARY AND NON GPL.
**
** COPYRIGHT    :              Copyright (c) 2013
**                          Lantiq Deutschland GmbH
**                   Am Campeon 3; 85579 Neubiberg, Germany
**
**   For licensing information, see the file 'LICENSE' in the root folder of
**   this software module.
**
** HISTORY

This file has been truncated. show original

Reflected_God · September 7, 2021, 12:13pm

After trying those lines I have discovered they are included in /etc/hotplug.d/net/20-smp-packet-steering. (OpenWrt 21.02)

Strange thing is TX cpus can't be modified, i.e.:

/sys/class/net/wlan0/queues/tx-0/xps_cpus
/sys/class/net/wlan1/queues/tx-0/xps_cpus

Does anybody know how can TX be tweaked?

Thank you.

nicefile · September 7, 2021, 12:22pm

I have good results using FB7412 and Open master 5.4 with pull 4353 and 4339 and with VPE-IRQ patch
Just three clicks to include them in OpenWrt master branch to benefit all

wilsonyan · October 20, 2021, 4:41am

now that there has been more of a push towards the kernel 5.10 and the DSA driver instead of the legacy driver it appers that there's been a fair amount of work to bring the things pc2005 worked on into the new driver

Extra stuff appears to be in this developer's branch : https://github.com/abajk/openwrt/commits/lantiq-jumbo-test

Like:

github.com

abajk/openwrt/blob/574c6559ebc499debc5cc11e093c7172871f7ed1/target/linux/lantiq/patches-5.10/0707-mips-lantiq-dma-test-packet-burst-arbitration.patch

From 37b7e58ee0e47a95d0fd3a1920de35c4e1fe9c74 Mon Sep 17 00:00:00 2001
From: Aleksander Jan Bajkowski <olek2@wp.pl>
Date: Fri, 8 Oct 2021 00:54:54 +0200
Subject: [PATCH] mips: lantiq: dma: test packet burst arbitration

---
 arch/mips/lantiq/xway/dma.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
index f8eedeb15f18..dbf576f12dc8 100644
--- a/arch/mips/lantiq/xway/dma.c
+++ b/arch/mips/lantiq/xway/dma.c
@@ -38,6 +38,7 @@
 #define DMA_PDEN		BIT(6)		/* enable packet drop */
 #define DMA_CHAN_RST		BIT(1)		/* channel on / off bit */
 #define DMA_RESET		BIT(0)		/* channel on / off bit */
+#define DMA_PKTARB		BIT(31)		/* packet arbitration */
 #define DMA_IRQ_ACK		0x7e		/* IRQ status register */
 #define DMA_POLL		BIT(31)		/* turn on channel polling */

This file has been truncated. show original

github.com

abajk/openwrt/blob/574c6559ebc499debc5cc11e093c7172871f7ed1/target/linux/lantiq/patches-5.10/0704-net-lantiq_xrx200-receive-fragmented-packets-via-fra.patch

From 17faec96dd31bfb338cc35200e4876965cfb915b Mon Sep 17 00:00:00 2001
From: Aleksander Jan Bajkowski <olek2@wp.pl>
Date: Sat, 9 Oct 2021 19:07:41 +0200
Subject: [PATCH] net: lantiq_xrx200: receive fragmented packets via frag_list

DMA split receive packet into multiple buffers in some cases.
If it occur create fragmented packet via frag_list.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
 drivers/net/ethernet/lantiq_xrx200.c | 39 +++++++++++++++++++++++-----
 1 file changed, 33 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
index 9b7307eba97c..b6752fe460b0 100644
--- a/drivers/net/ethernet/lantiq_xrx200.c
+++ b/drivers/net/ethernet/lantiq_xrx200.c
@@ -26,6 +26,9 @@
 #define XRX200_DMA_RX		0
 #define XRX200_DMA_TX		1

This file has been truncated. show original

However I am unable to get the ethernet ports working on my BT home hub 5a after merging this branch. Can anyone with serial access (so they don't brick their router unless they have a pre-existing config set to bridge a usb ethernet adapter onto br-lan) confirm that ? (kernel 5.10). The ports acknowlege there is a link is up but no ping or other access for me.

olek210 · October 20, 2021, 8:04pm

Hi @wilsonyan,
I am the original author of these patches. This is an older patch version and it is broken. Here is a newer version of the patch. This patch probably doesn't improve performance. You will find more patches in my repository. Some are untested.

Combining 4 patches increases performance by 25%:

I will send patches upstream on the next net-next cycle.

jekkos · October 21, 2021, 7:05am

I also saw you have a patch to use 4 TX queues, was any testing done on that one? I'm seeing a frequent 'tx ring buffer full' error that sometimes stalls the ethernet connection. Any idea if this patch could help to resolve that? Thanks!

olek210 · October 21, 2021, 4:57pm

The patch for TX queue 4 has not been tested. 'Tx ring buffer full' messages appear on the console because DMA is slow. The system fills the descriptors faster than dma releases them. I think patches from this PR should solve this problem.

olek210 · October 21, 2021, 5:00pm

Using all the patches I was able to achieve 725 Mb / s upload and around 600 Mb / s download speed.

jekkos · October 21, 2021, 9:10pm

impressive. So in this case the 4 patches you mentioned in your earlier post? If I understand correctly then most of them were sent upstream and it might take some time until they are pulled in openwrt?