Flow_offloading=1 is broken on latest snapshot (4.19 issue)

For Developers
30

Kernel bug: https://bugzilla.kernel.org/show_bug.cgi?id=204507

2 Likes
31

i've made a simple patch based on this and opened PR https://github.com/openwrt/openwrt/pull/2266 but, as expected, they claim their approach is correct and we should adjust openwrt offload patches...

i wonder which other devices use flow offloading feature besides openwrt routers, and if it is possible to reproduce regression on these as well

32

I recall this from the kernel bump back then which took a few weeks to handle properly. Especially this exact part.

Ill try to take a look at this asap after ath10k-ct

33

@psyborg I took your patch and added it to my own build. Software flow offloading is working fine again with a recent 4.19 trunk build :slight_smile:

1 Like
34

So is FO working again for all builds?

35

Nope, that would've been communicated at the various bug reports.
If you have Archer C7 v2, you can use my build from here: https://github.com/MOZGIII/archer-c7-v2-builds/tree/manual-4.19-2019-08-08-1
See instructions here: https://github.com/MOZGIII/archer-c7-v2-builds/blob/master/README.md

36

Do you have a patch or set of patches to enable s/w flow offload for the Archer C7v2?

(It wasn't clear from your GitHub repos where the changes were.)

37

I assume a build with PR2266

1 Like
38

Flow offload on 4.19 seems to break policy routing, even with the pr2266 patch.
I use iptables MARK/CONNMARK and ip rule to route some traffic to a tunnel interface. When a connection is offloaded, its packets hit the main routing table instead and leak to WAN, like how SFE breaks policy routing.

If I recall correctly, it works fine on 4.14.

@jeff @gwlim @quarky @psyborg

2 Likes
39

For now I have to disable flow offloading completely.

I just hope some developers will notice it and be willing to try fixing this mess.

40

So the fix is in, have not tried it myself.

2 Likes
41

It totally breaks the Internet..

1 Like
42

Same here...
//Edit
Works fine now. Thanks :smiley:
Let's see if ipv6 is stable now.

43

Yep, just flashed an image, she be dead Jim.

44

There has been an additional change a few minutes ago.
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=a438eac9ac98d98f594ec56ec023979be41035ca;hp=b2c55d50f8aeb21ef4cd3948034a158f7dd743c2

1 Like
45

Ya, still a no go for me.

46

"she be dead Jim" -- is this in general, or just if flow-offloading is enabled?

Edit: Resolved with subsequent pushes.

47

I did not try turning flowoffload off, just booted back to the other partition; so unsure. Gimme a sec and I will try.

Edit: so the latest patch push, with offload off is working.

2 Likes
48

Still Broken

Edit: after the recent change
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=c8933ce53365671de98a303c8d94e089ea76754e
There is already routing and it seems to work very well (tested on a Linksys Wrt32x)

gratitude

1 Like
49

OK, that seems to be working, thanks much.

1 Like