ERROR: package/feeds/packages/sstp-client failed to build

For Developers
1 
Making all in src/pppd-plugin
make[6]: Entering directory '/openwrt/build_dir/target-aarch64_generic_musl/sstp-client-1.0.19/src/pppd-plugin'

OpenWrt-libtool: compile: -o .libs/sstp_pppd_plugin_la-sstp-plugin.o

In file included from sstp-plugin.c:37:
sstp-pppd-compat.h:85:1: error: static declaration of 'ppp_add_options' follows non-static declaration

Followed by another bunch of:
"error: static declaration of 'ppp_blah' follows non-static declaration", with almost all referencing /staging_dir/target-aarch64_generic_musl/usr/include/pppd/pppd.h

And finally ending at:

make[6]: *** [Makefile:472: sstp_pppd_plugin_la-sstp-plugin.lo] Error 1
ERROR: package/feeds/packages/sstp-client failed to build.

Help?

2

Just to be sure this was not a build environment problem, I stood up a fresh Debian 12.7 and the same sstp-client snapshot build error persists there too. Also looked through git but could not determine that either sstp-client or ppp were updated recently, so I'm at a loss as to what has happened...

This identical snapshot build config (target, packages, etc.) built fine on October 11 (8 days ago) and produced the following versions without a problem:

Package: sstp-client
Version: 1.0.19-r2
Depends: libc, libevent2-7, libopenssl3, ppp, resolveip
Status: install ok installed
Architecture: aarch64_generic

Package: ppp
Version: 2.4.9_git20210104-r6
Depends: libc, kmod-ppp
Status: install ok installed
Architecture: aarch64_generic

-rwxr-xr-x    1 root     root        132193 Oct 11 17:37 /usr/bin/sstpc

-rwxr-xr-x    1 root     root        351619 Oct 11 17:37 /usr/sbin/pppd

Any ideas?

3

????
PPP was updated one week ago to 2.5.1 (on Oct 12).

Also the official buildbot fails now with sstp-client, so you are not alone.
E.g. https://downloads.openwrt.org/snapshots/faillogs/mips_24kc/packages/sstp-client/

4

Hnyman,

Not sure how I missed that; thank you. Hopefully sstpc is the only thing downstream that is affected.

I may try my hand at whipping up my own patch for it tomorrow to see if eliminating the now extraneous declarations fixes it.

5

Might be wise to upgrade sstp-client to 1.0.20...

Like already wished in https://github.com/openwrt/packages/issues/25134

6

Unfortunately it looks like this won't be that easy; I patched the Makefile to pull 1.0.20 and attempted an SDK build:

/build_dir/target-aarch64_generic_musl/sstp-client-1.0.20=sstp-client-1.0.20

As shown, the problem remains:

/openwrt-sdk-rockchip-armv8_gcc-13.3.0_musl.Linux-x86_64/build_dir/target-aarch64_generic_musl/sstp-client-1.0.20=sstp-client-1.0.20 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -c sstp-plugin.c  -fPIC -DPIC -o .libs/sstp_pppd_plugin_la-sstp-plugin.o
In file included from sstp-plugin.c:23:
sstp-pppd-compat.h:85:1: error: static declaration of 'ppp_add_options' follows non-static declaration
85 | ppp_add_options(option_t *options)                                                                                         
   | ^~~~~~~~~~~~~~~
In file included from sstp-pppd-compat.h:49:
/openwrt-sdk-rockchip-armv8_gcc-13.3.0_musl.Linux-x86_64/staging_dir/target-aarch64_generic_musl/usr/include/pppd/options.h:106:6: note: previous declaration of 'ppp_add_options' with type 'void(struct option *)'
106 | void ppp_add_options(struct option *options);
    |      ^~~~~~~~~~~~~~~
sstp-pppd-compat.h: In function 'ppp_add_options':
sstp-pppd-compat.h:87:5: warning: implicit declaration of function 'add_options'; did you mean 'ppp_add_options'? [-Wimplicit-function-declaration]
7

Possible fix has been committed by @Ansuel ...

8

Not possible. It is the fix in conjunction with the bump.

9

@Ansuel
This is confirmed. I've patched the sstp-client package to build 1.0.20, and everything build just fine now against ppp 2.5.1 with your latest commit. Resulting versions:

Package: sstp-client
Version: 1.0.20-r1
Depends: libc, libevent2-7, libopenssl3, ppp, resolveip
Status: install ok installed
Architecture: aarch64_generic
Conffiles:
 /etc/ppp/chap-secrets f8794bab47181801cb2e25f96f0861f9e8382ce8c0baf52c25967667586ce681
 /etc/ppp/peers/peer-sstp-example-nopty.txt a66c3d084a30b00c4a328af9d1f8a00f1030982b6b8d99dc64cd300464cd57de
 /etc/ppp/peers/peer-sstp-example.txt 45d616caa209ccc024d936c0c9ae81dba24bb4f374b00a039b4108d7d370f3b5
Installed-Time: 1729609063

Package: ppp
Version: 2.5.1-r1
Depends: libc, kmod-ppp
Status: install ok installed
Architecture: aarch64_generic
Conffiles:
 /etc/ppp/chap-secrets 6981fa176a79f8c12be5826c421b16253a616747018ba7e76752a9d36d1d51d4
 /etc/ppp/filter 579583b318e0cff706ffc134620b42d3fbce8fc31aeb0ad7eea1cc859868e902
 /etc/ppp/options 01f7358a5528be037dde329a2ecfb7a63382aababf21d4f5bc085f5acef95133
Installed-Time: 1729609063

Now we just need someone to bump the packages feed version of sstp-client to 1.0.20.

Thank you!

10

well guess how i discover the bug?

1 Like
11

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.