Creating Device Pages in LEDE Wiki

Yes. I reverted it.

[updated] Also on the Archer C7 page, I noticed several things in the "Installation" table:

  1. There were no URLs in the OpenWrt firmware columns. I changed the underlying datatable cols: definition by changing "Firmware Openwrt..." to "Firmware LEDE..." and the URLs showed up
    I don't know how to fix this globally - where is it most effective to change the definitions?

  2. I think the previous column headers were confusing. I changed them to:

  • OpenWrt Factory Firmware
  • OpenWrt Sysupgrade Firmware
  • OEM Stock Firmware
    I would like to use the same terminology in the Device Page as the flashing instructions, etc. to avoid confusion newcomers who are struggling to understand the various flavors.

The dataentries.
Still on my to do list, but I think I can manage the update during the weekend.

See also: https://openwrt.org/wiki/maintenance/to_do_list#dataentries

Regarding headers: They can be chosen as we wish.
How are we refering to them in everydays communication, firmware, or image, or...?

e.g.
"First you flash the OpenWrt factory firmware..."
"First you flash the OpenWrt factory image..."

Although I know that it is a firmware, I would download and flash the image to my router.
But that's only my personal, non-native speaker preference.

Great! Thanks!

Sounds like the subject of a new message...

... or is it a "firmware image" :slight_smile: ? Since we're the arbiters of style, I say we decide on our preferred wording and adjust all the "official" places to be consistent. (Obviously, we'll leave big hints that firmware == image in several places.)

Ermm... Your "ear" is extremely good. Don't sell yourself short. Thanks again.

1 Like

I have been horsing around with the <tabbox> method to display all the data collected by the data plugin/dataentries.

I like it because it's a compact and consistent way to display the most important information from about the device. I took the liberty of converting two Device Pages to use it:

The tables aren't in their final form, nor do they use all the fields that @tmomas is working on in the merged wiki. But my question is whether others think looks like a useful way to format the information. Thanks!

I added Model, Version + sorting to the datalist, because it is useless without for devices with multiple versions.

grafik

Yes, nice improvement. I wonder if there's any facility to include the comment header if its data is non-empty. That is, for each comment return:

  • "" if the string is empty
  • " v2 - WLAN Comment: 3x3" if the WLAN Comments is "3x3"

Here's another weird thought... The sole parameter to the entire <tabbox> structure is its Model. I wonder if there might be some way add that string as a parameter in an include, like this:

{{page>meta:tabbox-template&Archer C7 AC1750}}

so that the string after the '&' would be substituted in the obvious place in the replacement text before it's expanded within the device page.

That way, we can add a single line to a Device Page and all those specs show up

Good idea, but out of scope of the includes.

I experimented a bit with the datatemplatelist instead, because handing over a single parameter is what it currently does with the hardwaredetails.

Using datatemplatelist would result in:

  1. Creating all tables that are currently created by the data plugin by hand.
  2. Having multiple tabbox sections for multiple versions :frowning:

#1 is managable, but #2 is a real drawback.

Example: https://openwrt.org/playground/test_hwinfobox

Before this example I had datatables in the template_hwinfobox, but that didn't work at all ("Nothing found" in all datatables... :frowning:

Drat. Nevertheless, if we did decide to place a <tabbox> in every Device Page, we'd need a script to do it.

So "all we need to do" :slight_smile: is make the script (or the substituted text) somewhat fancier... Thanks for checking the boundaries on includes.

@thomas Questions on DataEntry/DataTable/DataList/Device Page...

  1. My copy of the Archer C7 page has several datatables, etc. In the Hardware Details, the three fields (Supported Since Commit, Supported Since Release, Supported Current Release) are always empty, even though the DataEntry has data for those items.

    I have lost my knowledge about the mapping between DataEntry -> DataTable -> Device Page. Would you tweak up that page so I can see how to show those values?

  2. Is there a way to combine two entries of a DataEntry (say the Owrt and LEDE forum pages)? The information doesn't deserve two columns in the Info Links tab - it would be nice to have either one shown (or both if they're both non-empty).

Thanks.

I already suspected an error in meta:template_hardwaredetailsheader, but that is OK.
It's much simpler:
image

Now changed to
image

-> All is working now on the Archer C7 page

Combining Forum links into one: Not possible as far as I know. We could of course do this manually, i.e. merge "OWrt Forum Topic URL" + "LEDE Forum Topic URL" in the dataenries into one (new) field "Forum topic URL".

Thanks, both for fixing the column names, and for the advice about combining the forum links. Let's not jump into extra work unless we really think it's needed.