# Comfast E314N-V2 **URL:** \ **Category:** For Developers\ **Created:** [February 2, 2019, 2:03pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483 "2019-02-02T14:03:28Z")\ **Posts on this page:** 20\ **Page:** 1
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [February 2, 2019, 2:03pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/1 "2019-02-02T14:03:29Z")
Hi Has this patch for Comfast E314N-V2 pulled into the git of OpenWrt ? [https://patchwork.ozlabs.org/patch/884850/](https://patchwork.ozlabs.org/patch/884850/) ---
**Author:** ![jeff](https://forum.openwrt.org/letter_avatar/jeff/32/5_5575768a8748004e209b776fc1b2916d.png) [@jeff](https://forum.openwrt.org/u/jeff)\ **Post date:** [February 2, 2019, 3:41pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/2 "2019-02-02T15:41:11Z")
![image](https://forum.openwrt.org/uploads/default/original/2X/f/f639f582b4b3874d46406b7394d3087d78be38f0.png) Ok, so maybe it didn't get closed out [https://openwrt.org/toh/start?dataflt[Brand\*~]=comfast](https://openwrt.org/toh/start?dataflt%5BBrand*~%5D=comfast) -- nope Ok, so maybe the ToH didn't get updated. Geeze, you've got the patch, so you know what you're looking for and where ``` jeff@deb-devel:~/devel/openwrt/target/linux/ar71xx$ fgrep -r e314n . jeff@deb-devel:~/devel/openwrt/target/linux/ar71xx$ ``` Nope ---
**Author:** ![tmomas](https://forum.openwrt.org/letter_avatar/tmomas/32/5_5575768a8748004e209b776fc1b2916d.png) [@tmomas](https://forum.openwrt.org/u/tmomas)\ **Post date:** [February 2, 2019, 5:30pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/3 "2019-02-02T17:30:18Z")
> [@jeff](#): > > Ok, so maybe the ToH didn't get updated. What update do you expect? ---
**Author:** ![jeff](https://forum.openwrt.org/letter_avatar/jeff/32/5_5575768a8748004e209b776fc1b2916d.png) [@jeff](https://forum.openwrt.org/u/jeff)\ **Post date:** [February 2, 2019, 6:04pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/4 "2019-02-02T18:04:04Z")
(Just showing the path I used to confirm device wasn’t supported.) ---
**Author:** ![Borromini](https://forum.openwrt.org/letter_avatar/borromini/32/5_5575768a8748004e209b776fc1b2916d.png) [@Borromini](https://forum.openwrt.org/u/Borromini)\ **Post date:** [February 2, 2019, 7:45pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/5 "2019-02-02T19:45:00Z")
@grosjo It looks like the author did file the patch for inclusion but there was no follow-up (nothing further on the mailing list). I can try to apply the patch to the current codebase (18.06.2 or master) and build you an image if you'd like (so you can test) - but that means you should be able to recover if needed (the author no doubt tested his patch but if it breaks it breaks, and you get to keep all the pieces). Keep in mind all ar71xx supported devices need to be migrated to ath79 (DTS-based) at some point and this patch 'only' provides ar71xx support. I don't have the skillset to turn this into an ath79 patch, but once you have ar71xx up and running on yours you might apply [here](https://forum.openwrt.org/t/porting-guide-ar71xx-to-ath79/) and maybe someone is kind enough to pick up your request. Let me know. ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [February 2, 2019, 11:33pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/6 "2019-02-02T23:33:35Z")
@borromini, thanks for the note. I would appreciate if the patch gets into master. I maybe be able to test it probably in a month or so. As for migrating to Ath79, I can put some effort in this. I tried to go through the 890 comments on the topic ij the forum, but is there a formal documentation somewhere about it ? ---
**Author:** ![jeff](https://forum.openwrt.org/letter_avatar/jeff/32/5_5575768a8748004e209b776fc1b2916d.png) [@jeff](https://forum.openwrt.org/u/jeff)\ **Post date:** [February 3, 2019, 4:58am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/7 "2019-02-03T04:58:37Z")
- [https://openwrt.org/submitting-patches#dts\_checklist](https://openwrt.org/submitting-patches#dts_checklist) - [https://openwrt.org/docs/guide-developer/defining-firmware-partitions](https://openwrt.org/docs/guide-developer/defining-firmware-partitions) - [https://devicetree-specification.readthedocs.io/en/latest/source-language.html](https://devicetree-specification.readthedocs.io/en/latest/source-language.html) - [https://elinux.org/Device\_Tree\_Mysteries](https://elinux.org/Device_Tree_Mysteries) Additionally: Partitions should have node labels of partition@\ Boot loader, art, and similar critical partitions marked read-only "firmware" mtd label for NOR, "ubi" for NAND, can't both be present, however > Auto-splitting "firmware" partition (by its name) is enabled by: > CONFIG\_MTD\_SPLIT\_FIRMWARE > > If you use a proper compatible string it doesn't has to be named > "firmware" and you don't need CONFIG\_MTD\_SPLIT\_FIRMWARE Tab indentation cpp-style #include (not device tree /include/) [https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst) ---
**Author:** ![Borromini](https://forum.openwrt.org/letter_avatar/borromini/32/5_5575768a8748004e209b776fc1b2916d.png) [@Borromini](https://forum.openwrt.org/u/Borromini)\ **Post date:** [February 4, 2019, 11:15am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/8 "2019-02-04T11:15:22Z")
> [@grosjo](#): > > I would appreciate if the patch gets into master. Understandably. Since it's a bit stale at this point that would mean you'd need to test it and report to the mailing list for follow-up. You might try prodding the author if needed. ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [February 25, 2019, 11:03pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/9 "2019-02-25T23:03:25Z")
First I will ensure the ar71xx is working. New repo here : [https://github.com/grosjo/openwrt-comfast-e314n-v2/](https://github.com/grosjo/openwrt-comfast-e314n-v2/) ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [February 28, 2019, 1:40pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/10 "2019-02-28T13:40:24Z")
Pull request made > ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [March 2, 2019, 7:15am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/11 "2019-03-02T07:15:53Z")
ok, my pull request has been refused. How frustrating. And sill no clue how to port this ti "ath79". Isn't there a RTFM somewhere ? ---
**Author:** ![jeff](https://forum.openwrt.org/letter_avatar/jeff/32/5_5575768a8748004e209b776fc1b2916d.png) [@jeff](https://forum.openwrt.org/u/jeff)\ **Post date:** [March 2, 2019, 7:51am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/12 "2019-03-02T07:51:04Z")
In the main, since your device seems very similar to others, see how their DTS is created through `#include` statements, learn how to add/remove/modify DTS nodes and properties, and do it. There doesn’t look to be much involved from the changes in the mach file. ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [March 2, 2019, 8:16am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/13 "2019-03-02T08:16:30Z")
Yes, but actually all other simialr e316n, e320n, etc.. are in ar71xx , not in ath79 So, somehow, I need to know how does the ar71xx -\> ath79 process works. Isn't there a doc somewhere ? ---
**Author:** ![tmomas](https://forum.openwrt.org/letter_avatar/tmomas/32/5_5575768a8748004e209b776fc1b2916d.png) [@tmomas](https://forum.openwrt.org/u/tmomas)\ **Post date:** [March 2, 2019, 8:41am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/14 "2019-03-02T08:41:11Z")
Take a look at [Porting guide ar71xx to ath79?](https://forum.openwrt.org/t/porting-guide-ar71xx-to-ath79/13013) ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [March 30, 2019, 6:19pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/16 "2019-03-30T18:19:11Z")
Plese kindly review > ---
**Author:** ![anon4457646](https://forum.openwrt.org/letter_avatar/anon4457646/32/5_5575768a8748004e209b776fc1b2916d.png) [@anon4457646](https://forum.openwrt.org/u/anon4457646)\ **Post date:** [May 10, 2019, 8:31pm UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/17 "2019-05-10T20:31:18Z")
any news about this device? ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [May 11, 2019, 8:05am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/18 "2019-05-11T08:05:51Z")
PR is here : [https://github.com/openwrt/openwrt/pull/1955](https://github.com/openwrt/openwrt/pull/1955) All is working fine, I am just a bit desesperate to find some admin willing to push it to master ---
**Author:** ![jeff](https://forum.openwrt.org/letter_avatar/jeff/32/5_5575768a8748004e209b776fc1b2916d.png) [@jeff](https://forum.openwrt.org/u/jeff)\ **Post date:** [May 11, 2019, 8:19am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/19 "2019-05-11T08:19:49Z")
People wishing to build based on your PR can always download a patch from [https://patch-diff.githubusercontent.com/raw/openwrt/openwrt/pull/1955.patch](https://patch-diff.githubusercontent.com/raw/openwrt/openwrt/pull/1955.patch) (add `.patch` to the PR URL). It then can be locally applied with something like `git am 1955.patch`. I would suggest checking out a new branch _before_ applying the patch, rather than applying it directly to the local copy of `master`. * * * _Edit:_ The above URL comes from taking the PR URL [https://github.com/openwrt/openwrt/pull/1955](https://github.com/openwrt/openwrt/pull/1955) and adding the `.patch` extension to get [https://github.com/openwrt/openwrt/pull/1955.patch](https://github.com/openwrt/openwrt/pull/1955.patch) (which then redirects to the patch content URL, shown above). ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [May 11, 2019, 8:02am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/20 "2019-05-11T08:02:29Z")
PR is here : [https://github.com/openwrt/openwrt/pull/1955](https://github.com/openwrt/openwrt/pull/1955) All is working fine, I am just a bit desesperate to find some admin willing to push it to master ---
**Author:** ![grosjo](https://forum.openwrt.org/user_avatar/forum.openwrt.org/grosjo/32/9451_2.png) [@grosjo](https://forum.openwrt.org/u/grosjo)\ **Post date:** [May 11, 2019, 10:17am UTC](https://forum.openwrt.org/t/comfast-e314n-v2/30483/21 "2019-05-11T10:17:26Z")
@jeff thank you for the tip however, do you know the process to convert this PR into master code ? [Next page](https://forum.openwrt.org/t/comfast-e314n-v2/30483.md?page=2)