vochong
October 31, 2024, 9:23pm
101
Hi @rkboni
Since you have MR52, can you please also take a look at this LED-related issue for MR52. Thanks!
opened 01:00AM - 31 May 24 UTC
target/ipq806x
bug
release/23.05
Official Image
Supported Device
### Describe the bug
MR52 dts defines "red:user", "green:user", "blue:user" for… the system LED but 'ls -al /sys/class/leds/' does not show any of them. The problem is seen in 23.05.3 as well as the latest master snapshots.
MR52 dts:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8068-mr52.dts;h=e1c233254d25dddbc8fb6f9cf00fade407180926;hb=67f52012760ce553ba6393aaba77359a458deeda
118 tlc591xx@49 {
119 #address-cells = <1>;
120 #size-cells = <0>;
121 compatible = "ti,tlc59108";
122 reg = <0x49>;
123
124 red@0 {
125 label = "red:user";
126 reg = <0x0>;
127 };
128
129 green@1 {
130 label = "green:user";
131 reg = <0x1>;
132 };
133
134 blue@2 {
135 label = "blue:user";
136 reg = <0x2>;
137 };
root@mr52:~# ls -al /sys/class/leds/
lrwxrwxrwx 1 root root 0 May 29 09:01 ath10k-phy0 -> ../../devices/platform/soc/1b500000.pci/pci0000:00/0000:00:00.0/0000:01:00.0/leds/ath10k-phy0
lrwxrwxrwx 1 root root 0 May 29 09:01 ath10k-phy1 -> ../../devices/platform/soc/1b700000.pci/pci0001:00/0001:00:00.0/0001:01:00.0/leds/ath10k-phy1
lrwxrwxrwx 1 root root 0 May 29 09:01 ath10k-phy2 -> ../../devices/platform/soc/1b900000.pci/pci0002:00/0002:00:00.0/0002:01:00.0/leds/ath10k-phy2
lrwxrwxrwx 1 root root 0 Dec 31 1969 green:lan1 -> ../../devices/platform/leds/leds/green:lan1
lrwxrwxrwx 1 root root 0 Dec 31 1969 green:lan2 -> ../../devices/platform/leds/leds/green:lan2
lrwxrwxrwx 1 root root 0 Dec 31 1969 orange:lan1 -> ../../devices/platform/leds/leds/orange:lan1
lrwxrwxrwx 1 root root 0 Dec 31 1969 orange:lan2 -> ../../devices/platform/leds/leds/orange:lan2
lrwxrwxrwx 1 root root 0 Dec 31 1969 orange:power -> ../../devices/platform/leds/leds/orange:power
lrwxrwxrwx 1 root root 0 Dec 31 1969 white:active -> ../../devices/platform/leds/leds/white:active
For MR42, similar definitions are present in the MR42 dts and they show up properly in ls -la /sys/class/leds/
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8068-mr42.dts;h=ccf2554ca319fa2b36cd37f4da1859d9e7699c5f;hb=67f52012760ce553ba6393aaba77359a458deeda
root@mr42:~# ls -la /sys/class/leds/
lrwxrwxrwx 1 root root 0 May 29 00:48 ath10k-phy0 -> ../../devices/platform/soc/1b500000.pci/pci0000:00/0000:00:00.0/0000:01:00.0/leds/ath10k-phy0
lrwxrwxrwx 1 root root 0 May 29 00:48 ath10k-phy1 -> ../../devices/platform/soc/1b700000.pci/pci0001:00/0001:00:00.0/0001:01:00.0/leds/ath10k-phy1
lrwxrwxrwx 1 root root 0 May 29 00:48 ath10k-phy2 -> ../../devices/platform/soc/1b900000.pci/pci0002:00/0002:00:00.0/0002:01:00.0/leds/ath10k-phy2
lrwxrwxrwx 1 root root 0 Dec 31 1969 blue:user -> ../../devices/platform/soc/16500000.gsbi/16580000.i2c/i2c-1/1-0040/leds/blue:user
lrwxrwxrwx 1 root root 0 Dec 31 1969 green:user -> ../../devices/platform/soc/16500000.gsbi/16580000.i2c/i2c-1/1-0040/leds/green:user
lrwxrwxrwx 1 root root 0 Dec 31 1969 orange:power -> ../../devices/platform/leds/leds/orange:power
lrwxrwxrwx 1 root root 0 Dec 31 1969 red:user -> ../../devices/platform/soc/16500000.gsbi/16580000.i2c/i2c-1/1-0040/leds/red:user
lrwxrwxrwx 1 root root 0 Dec 31 1969 white:active -> ../../devices/platform/leds/leds/white:active
### OpenWrt version
r23809-234f1a2efa
### OpenWrt release
23.05.3
### OpenWrt target/subtarget
ipq806x/generic
### Device
Cisco Meraki MR52
### Image kind
Official downloaded image
### Steps to reproduce
_No response_
### Actual behaviour
_No response_
### Expected behaviour
_No response_
### Additional info
_No response_
### Diffconfig
_No response_
### Terms
- [X] I am reporting an issue for OpenWrt, not an unsupported fork.
rkboni
October 31, 2024, 10:46pm
102
@vochong I'll give this a look after I get my MR42's in (and validate / fix the MAC address setup issues there), which will allow me to free up a MR52 to put in my "lab" network where I can actually look at the LEDs.
Ping me if you don't hear anything in a week or two.
2 Likes
vochong
November 3, 2024, 12:10am
103
@rkboni
As I mentioned in the defect, the RGB LED works perfectly in MR42.
1 Like
rkboni
November 4, 2024, 4:51am
104
Yep, but right now my MR52's are busy... once I get an MR42, I can swap in an MR42 for one of the MR52's so I can debug the MR52 LEDs.
rkboni
November 4, 2024, 10:13pm
105
The fix for the MR42 MAC address issue is now in the OpenWRT 23.05 branch thanks to @robimarko .
Installing the MR42 took way longer than actually testing the fix -- and I fried one of my Raspberry Pi's because I mistook the triangle under the 3.3V pin for the number 4 and connected the serial cable backwards
1 Like
rkboni
November 4, 2024, 10:26pm
106
It's interesting that in the MR42 there are 2 I2C busses and the tlc591xx
is on the second bus, whereas on the MR52 there's only a single I2C bus that has the ina219
, tlc59108
and the 24c64
.. why would the simpler hardware have two busses? I guess it could be because they const-reduced the MR52, but still seems odd to me...
UPDATE: I haven't had any time to keep poking at the MR-52 LED issues recently but have some more ideas I'll hopefully look at over the holidays or early in the new year.
1 Like