7692

I have made the PR :grin:

7693

all working fine after applying the patch against both the ax3600 and dynalink ...no noticeable improvement for my use case

7694

Just to revive this information from a few months ago:

To check the actual frame mode, use cat /sys/module/ath11k/parameters/frame_mode

Based on the output:

Datapath frame mode (0: raw, 1: native wifi (default), 2: ethernet)

MOD: strange... After I pulled the PR and rebuilt everything, frame_mode is still 1.

7695

@dchard and @robimarko I made a mistake, and I have made a pull request to fix it, it didn't have autoload and so the parameter couldn't be added... Sorry :sweat::sweat::sweat:

1 Like
7696

are you actually unit testing what you are proposing beforehand?

7697

This comment wasn't needed publicly. If you sincerely wanted to know, you could have direct messaged him.

I'll ask you the same question based on this:

7698

We haven't seen your PR's adding anything to this (or any other) opensource project, but you commented that "all working fine". If it is all working fine, then what is your problem? And if it isn't, why did you wrote that it does? Are you properly testing or just commenting that "all is working fine" ?? Commenting, but no actual testing?

7699

Hm, so if AUTOLOAD is not present then config file in /etc/modules.d is not generated?

7700

It is not. On my end ath11k file is not present. Only ath11k_ahb is.

7701

Yhea i notice that too... to use modparam you require autoload
example for the nss offload i had to add autoload for ath11k (to pass the frame_mode and other params)

7702

Ok, its a bit stupid logic as I intentionally did not add autoload since the submodules will load its dependencies.

1 Like
7703

I am building with his fix, let me quickly try if it works. Will report back.

7704

btw for nss offload the frame_mode=2 is mandatory so i already tested that and works
qsdk also have a patch to set the frame mode to ethernet by default directly in the driver

7705

Tested the fix, it works so I added a comment why is that module param being set and squashed it with the original commit.

Its already pushed and building

7706

I can confirm that it does work, the frame_mode is now 2.

7707

Yes that is the case, and since I had the parameter configured in modules.conf it applied them, and I forgot about that

Thanks for squashing the commits!

7708

yes all is working fine .. no material effect ? what is your problem and why you are being a bully ? and why not saying it to test it before posting a PR ... this is not criticism grow up mate ! it is agile ...failures happen and so what we learn? i am very sorry I hurt people's feelings

7709

Dude, chill with the passive-agressive comments.

14 Likes
7710

Ansuel thank you for your 5.15-pr-wifi-offload firmware with nss offload. To me it is noticeably faster.
Please help to push updated build to sync with robimarko's build.

Again. Appreciate all the good work done by all to make this possible.

the nss offload patches were not included in robimarko. Any reason why those patches were not used?

7711

Could we also include this fix by default? I just had to flash six times to update to the newest build.

Also I can confirm that at its set to "ath11k frame_mode=2" in etc/modules.d/ath11k.

1 Like