Adblock support thread

Thanks, fixed in luci master & 19.07 ...

Just upgraded to 4.0.4.
The interface looks really different now, as do source names. I'm kinda confused.
Any recommendations for best source selection? I'm on a R7800.

Is this an overkill? :confused:

Hello,

Just updated (then removed, reinstalled and did it a few times) to AdBlock 4.0.4-3 & the Luci app on a WRT32x.

When I go to the luci Service for Adblock, the overview page hangs with:

TypeError

result[0].trim is not a function

Had no issues in any prior version. Have removed luci temp files and all. Is this a known issue or something easily fixable?

Thanks in advance. <edits are correcting English that gave me an eyesore!!! :slight_smile:)

@xbrico 4.0.4-2 was working?

Up until last week or 2 weeks maybe which is when I last did a pkg update, AdBlock was 3.8.15-1 it seems

Did you delete config and start from scratch and rebooted router?

Sure did sir. Did a pgk upgrade and thats when I 1st noticed it didnt work. Got a JSON page error so saw a command to remove temp files. Did that and it moved to the above error. After that, I stopped service, deleted Adblock /etc/config file and the whitelist files I had in /etc/adblock. Then uninstalled and reinstalled the software. Same error appears.

as an addendum to this, it only does the error on the "Overview" tab. Doesn't appear on the other tabs.

Ok, so your advice is not to upgrade to 4.0.4-3...... ;- )

4.0.4-3 is what OpenWRT is providing at the moment

Please post the output of cat /etc/openwrt_release

root@OpenWrt:/etc/config# cat /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='19.07.1'
DISTRIB_REVISION='r10911-c155900f66'
DISTRIB_TARGET='mvebu/cortexa9'
DISTRIB_ARCH='arm_cortex-a9_vfpv3'
DISTRIB_DESCRIPTION='OpenWrt 19.07.1 r10911-c155900f66'
DISTRIB_TAINTS=''

Please update to latest stable first (19.07.2)

Seriously? Have a massive rebuild to do then for DNSSEC, Stubby,Firewalls and the likes!!! Device is running on ExtRoot so no such thing as a simple "upgrade" :confused:

Yep, there have been so many LuCI-related changes ... and adblock has only be tested with latest stable.

removal it is for the time being then! :confused:

It is running all the latest revisions of luci though?

Upgrading luci-app-adblock on root from git-20.096.65488-81ad3bb-1 to git-20.105.64099-eeba108-1...

Also, If your part of the dev team, would it not be worth telling the OpenWRT people that your git is wrong and it hasn't been tested on 19.07.x (all stable and devel releases) which your git does state? Could maybe get a roll back from them as they appear to think its supposed to be stable and have put it in version 19.07.1 update repository!

I've tested quickly with 19.07.1:

root@OpenWrt:~# /etc/init.d/adblock status_service
::: adblock runtime information
  + adblock_status  : enabled
  + adblock_version : 4.0.4
  + blocked_domains : 36872
  + active_sources  : adaway adguard disconnect yoyo 
  + dns_backend     : dnsmasq, /tmp/dnsmasq.d
  + run_utils       : /bin/uclient-fetch, /usr/bin/awk
  + run_ifaces      : trigger: wwan, report: -
  + run_directories : base: /tmp, backup: /tmp, report: /tmp, jail: /tmp
  + run_flags       : backup: 1, reset: 0, flush: 0, force: 1, search: 0, report: 0, mail: 0, jail: 0
  + last_run        : start, 0m 43s, 125/87/70, 18.04.2020 19:37:37
  + system          : GL-MT300N-V2, OpenWrt 19.07.1 r10911-c155900f66

Works for me, I have to update all luci core components plus rpcd ...

Hello, Have tried the now updated 4.0.4-4, still same with all the latest luci components:

Sticks on this:

Shows service is started but will need to be totally manually configured. As OpenWRT have now added this to their core packages directory, could cause a few issues.