Could you please test adblock-fast 1.1.0-5 from my repo? Also, please update the luci app as well, I fixed a bug there.
Hello Stangri.
I have come back to my machine.
Installing the luci-app gives me this error and the widget does not complete installation far enough to appear in the menus.
Installing luci-app-adblock-fast (1.1.0-5) to root...
Downloading https://repo.openwrt.melmac.net/luci-app-adblock-fast_1.1.0-5_all.ipk
Configuring luci-app-adblock-fast.
uci: Parse error (too many arguments) at line 126, byte 135
Cheers 
What's the output of for i in /etc/config/*; do if ! uci show ${i##*/} > /dev/null 2>&1; then echo -e -n "$i: "; uci show ${i##*/} > /dev/null; fi; done; ?
It does sound like an error in the config-file.
Hello, I am new to openwrt.
I would like to run adblock-fast on netgear r7800 with smart dns alreday running on it. I have followed the steps and installed the dependencies as noted here: https://docs.openwrt.melmac.net/adblock-fast/
I choose smartdns in the luci and keep getting the error:
I have restarted the router and adblock but it seems to be stuck here
There is nothing.
I am using the latest config that came with 1.1.0.5 into adblock-fast-opkg
mv adblock-fast-opkg adblock-fast FYI
The adblock-fast menu does not appear after reinstallation of both adblock-fast service & luci-app
What's the error?
Weird, can you try rebooting the router?
Yessir.
It was finally a mistake on my side and there must have been something wrong with the config.
Removal of both app & service, deleting the lingering config, rebooting the router and reinstalling first service, enabling it, then installing the luci-app, made it appear in the config web-app.
I am going to check for you if installation of both at the same time is going to work for me.
Edit: The app & service now work fine on default config, installed at the same time. THANK YOU kindly.
1 Like
Either it keeps saying: starting adblock service
After restarting router:
but when i choose dnsmasq config it shows that is working. But doesnt block any ads. Smartdns in luci is running fine on port 53
One last thing.
When starting the service from web-ui, I got "failed to parse allow list".
Stopping and starting the service from cli, made the service start correctly.
Thanks for trying it out and your perserverance with it while I was adding some new functionality and sadly bugs. 
1 Like
When you stop it from WebUI, does the WebUI say cache file found?
I just tested the domainset with smartdns and it works fine. It was also tested by the smartdns maintainer and it worked fine for them.
The list processing is the most CPU/time-consuming operation. Depending on the size of the lists, the length of your allow-lists and the router's CPU the list processing may take a few minutes. Sadly, the WebUI doesn't update itself during the process, so you may want to refresh the page after a minute or so.
1 Like
Yes it is working when you choose smartdns domain option but cant get it work with ntf set. Does it work wiyj ntf options on your side?
Thank you
Yes, I don't have any issues with smartdns.nftset option either, so whatever error you're experiencing, I cannot reproduce.
PS. What's the reason you want to run it with the smartdns.nftset option vs smartdns.domainset?
Actaully I dont know much the difference between all three profiles there of the smartdns. But thought .nftset option blocks ads in browsers that run on https (probably wirng assumption)
If you are aware of the differences in all three profiles ( .domaiset vs .nftset vs ipset) it would be good to know.
I would try on another router gl. MT6000 (being delivered in two days).Thank you for the package and responses
No, this is a correct assumption. But you can also try adding Canary domains to the block-list in an attempt to make the browsers stop using their built-in DoH and use one on your router (like https-dns-proxy).
If the domainset is working, but nftset is not, maybe you should bring it up with the smartdns dev/maintainer, I know next to nothing about that resolver.
I'd appreciate if anyone (and @dave14305 specifically) can test adblock-fast 1.1.0-8 (and corresponding luci app) -- I rewrote code which was responsible for deciding if the service should redownload all lists or just quickly restart on config changes, as well as significantly improved (I hope) the code the fw4 restart decisions.
For now the new packages are available in my dev repo only (https://dev.melmac.net/repo/), I may push them to my OpenWrt repo in a few days after testing locally.
I uninstalled the previous version of the plugin and installed adblock-fast 1.1.1-1 and luci-app-adblock-fast 1.1.1-1 and received the following errors:
Summary
Thu Dec 14 22:49:54 2023 user.notice adblock-fast [2213]: ERROR: adblock-fast is currently disabled!
Thu Dec 14 22:49:54 2023 user.notice adblock-fast [2213]: Run the following commands before starting service again:
Thu Dec 14 22:49:54 2023 user.notice adblock-fast [2213]: uci set adblock-fast.config.enabled='1'; uci commit adblock-fast;
Thu Dec 14 22:49:54 2023 user.notice adblock-fast [2213]: ERROR: adblock-fast is currently disabled!
Then in the file /etc/config/adblock-fast
In the option enabled line - I replaced 0 with 1
Summary
config adblock-fast 'config'
option enabled '1'
list allowed_domain 'cdn.jsdelivr.net'
option allow_non_ascii '0'
.....
I rebooted the router and got the following errors:
Summary
Fri Dec 15 06:05:59 2023 user.notice adblock-fast [2243]: WARNING: some recommended packages are missing, install them by running:
Fri Dec 15 06:05:59 2023 user.notice adblock-fast [2243]: opkg update; opkg --force-overwrite install gawk grep sed coreutils-sort;
Although there were no errors during installation and several packages were automatically installed along with this plugin, which I unfortunately did not remember.
Also further in the log you can see the following message:
Summary
Dec 15 06:06:01 2023 user.notice adblock-fast [2243]: Waiting to discover WAN Interface...
In this router, there is no cable connected to the WAN and the Internet is received via WiFi.
This did not harm previous versions of this plugin in any way)))
Working as intended.
Working as intended.
If your wwan interface has a default route, it should be picked up as WAN interface by this. Obviously the goal is to not start adblock-fast before there's internet connectivity and I'm using built-in OpenWrt tools to discover when WAN is up.