Adblock-fast: ad-blocking service for dnsmasq, smartdns and unbound

dave14305 · 2024-10-25T17:46:13.140Z

On the plus side, everything is working well based on my 3 alllowlist scenarios! Thank you.

stangri · 2024-10-29T22:13:15.957Z

I have previously ignored the news about the per-instance conf-dir support for dnsmasq (applicable for dnsmasq.conf, dnsmasq.ipset and dnsmasq.nftset configurations only), but was reminded about it with the recent drama with switching default values for per-instance conf-dir.

The adblock-fast 1.1.2-10 (and please update the luci app to the same version), has support with configurable per-instance conf-dir for dnsmasq. I've quickly tested with all 3 options affected (and dnsmasq.servers which is not affected) and it seemed to work for me.

If you use adblock-fast with either dnsmasq.conf, dnsmasq.ipset or dnsmasq.nftset options for resolver, especially if you have multiple dnsmasq instances, please install 1.1.2-10 and test.

Pending any reported bugs, I'll be creating PRs for OpenWrt packages both snapshots and 23.05 repos before the end of the week.

dave14305 · 2024-11-13T22:03:02.831Z

I observed some “Unknown warning” lines in LuCI after installing a new build from sources. I neglected to install the recommended packages (gawk, grep, sed, coreutils-sort) and get the warning as expected.


Service Warnings        Some recommended packages are missing
                        Unknown warning
                        Unknown warning
                        Unknown warning

I thought the extra warnings odd and checked the json response:

"warnings": [
        {
                "id": "warningMissingRecommendedPackages",
                "extra": "gawk"
        },
        {
                "id": "grep",
                "extra": ""
        },
        {
                "id": "sed",
                "extra": ""
        },
        {
                "id": "coreutils-sort",
                "extra": ""
        }
],

The additional packages each create a separate id, and so the id doesn’t match a pre-defined warning text. Not a showstopper, but perhaps the json needs tweaking if multiple packages are missing?

This is a build off snapshot (actually the pesa1234 build for MT6000, but same official “packages” repo for Adblock-fast).

stangri · 2024-11-13T22:32:17.895Z

Thanks @dave14305, was super-easy to fix since you've done all the work diagnosing it!

Fixed in adblock-fast 1.1.2-12, due to the modified i8n strings, would also require update of the luci-app.

The APK-compatible binaries can be found at https://dev.melmac.net/apk/

This is how the fixed luci app looks:

image864×68 3.78 KB

dave14305 · 2024-11-13T23:16:08.028Z

Sorry, I’m in no-man’s-land between opkg and apk right now. Have you pushed the source anywhere yet?

Nevermind, remembered the old repo path for ipk.

stangri · 2024-11-14T01:19:08.766Z

apk repo/binaries: https://dev.melmac.net/apk/
opkg/ipk repo/binaries: https://dev.melmac.net/repo/

anomeome · 2024-11-15T21:32:28.173Z

Running a x86 master image, issuing

/etc/init.d/adblock-fast stop

deletes the config file; apk is a bit borked so version is whatever is currently in master.

dave14305 · 2024-11-15T22:27:47.474Z

Did you happen to be in the config directory when you ran the stop?

I wanted to test this, so I copied my config file to ~/adblock-fast and then ran the stop and afterwards, the config file was still in /etc/config, but the backup in my current directory had disappeared.

anomeome · 2024-11-15T22:29:12.033Z

Yep, current dir was /etc/config.

dave14305 · 2024-11-15T22:45:32.809Z

@stangri the dnsmasqConfFile without a path causes this here:

github.com

openwrt/packages/blob/3d6cfc732b67549a770b5a4016024ebaef51dfda/net/adblock-fast/files/etc/init.d/adblock-fast#L768C47-L768C62


      
          	[ "$dns" = 'dnsmasq.conf' ]       || rm -f "$dnsmasqConfFile" "$dnsmasqConfCache" "${compressed_cache_dir}/${dnsmasqConfGzip}"

github.com

openwrt/packages/blob/3d6cfc732b67549a770b5a4016024ebaef51dfda/net/adblock-fast/files/etc/init.d/adblock-fast#L36-L36


      
          readonly dnsmasqConfFile="${packageName}"

+ '[' dnsmasq.servers '=' dnsmasq.conf ]
+ rm -f adblock-fast /var/run/adblock-fast/dnsmasq.conf.cache /etc/adblock-fast.dnsmasq.conf.gz

stangri · 2024-11-16T01:07:51.476Z

Thanks @anomeome for posting and @dave14305 for investigating, it did sound like a bigger issue than just apk compatibility and I'll take @dave14305 findings to fix this, hopefully over the weekend!

stangri · 2024-11-18T20:56:05.147Z

Looks like StevenBlack's hosts file currently has some erroneous entries which break dns resolution if used.

Disable that source (if you're using it) and update to adblock-fast 1.1.2-16 for fix.

pusentru · 2024-12-26T15:03:18.474Z

I'm currently trying to setup adblock-fast on a second dnsmasq instance that is only used by specific devices.
I also have stubby running which uses 127.0.01#5453 (+ipv6) on the main instance.

I don't get what im doing wrong, I also don't get how to configure the ports correctly. The second dnsmasq instance (where adblock-fast is pointing) needs a different dns port because you can't run multiple thongs on port 53. What port do I pick? How is this related to the force dns port option? Do I need to setup some firewall rules?

Custom dns on the LAN interface is clear, custom dns on WAN points to cloudflare.

Would love some help.

(dnsmasq-full is installed)

stangri · 2024-12-27T22:43:32.742Z

pusentru:

I don't get what im doing wrong, I also don't get how to configure the ports correctly. The second dnsmasq instance (where adblock-fast is pointing) needs a different dns port because you can't run multiple thongs on port 53. What port do I pick? How is this related to the force dns port option? Do I need to setup some firewall rules?

The way hijacking is implemented in adblock-fast, it maps the hijacked port from the requests to an open port on the router or drops the requests if this port is not open on the router. In your case, the clients are likely to send requests to hard-coded DNS servers still on port 53, whereas the target dnsmasq instance is not going to be running on port 53, so yes, you may have to set up the hijack firewall rules manually. Maybe it would be easier to configure adblock-fast on the primary (port 53) dnsmasq instance and set your LAN clients where you don't need adblocking to use an alternative instance.

openwide · 2024-12-28T13:07:41.349Z

Is there a quick way to suspend/resume ad blocking without having to restart the service?

I have a toggle switch running in HomeAssistant (HA) meant for toggling ads
It can SSH into the router and perform commands
The 3 I need are: suspend, resume and status
adblock has all 3, but it was extremely slow in updating status to the actual value, this makes the toggle switch unusable
I tried the various commands of adblock-fast but they all seem to start and stop the service which is just as slow
Any ideas? Thank you!

stangri · 2024-12-30T17:19:25.690Z

openwide:

Is there a quick way to suspend/resume ad blocking without having to restart the service?

The actual adblock-fast stop/start operations are very fast, it's usually resolver (in default installs -- dnsmasq) where restarts are expensive operations. You may want to set dhcp.lan.force=1 to speed it up a bit.

openwide · 2024-12-31T13:05:27.454Z

But I do run service dnsmasq restart for other purposes, and it does not take as long as restart the adblock-fast

What does dhcp.lan.force=1 do?

fdauti · 2025-01-01T00:35:29.242Z

How can I change the StevenBlack - Unified Hosts file? In the StevenBack github repo there are meny combinations of this file, but how to replace the default one in AdblockFast with the one I want to use. Or just an easy way to add it as new, since just adding the github link will not work.

stangri · 2025-01-01T05:21:50.386Z

openwide:

But I do run service dnsmasq restart for other purposes, and it does not take as long as restart the adblock-fast

What kind of time difference are we talking about? What's the output of adblock-fast on stop/start?

fdauti:

How can I change the StevenBlack - Unified Hosts file?

I'm failing to see what could prevent you from editing/adding new URL given the WebUI and CLI are well documented.

fdauti · 2025-01-01T12:35:23.928Z

When I try to add the link through the add button it doesn't get processed when AdBlock is started, will appear with that red-cross when i restart through the command line. Obviously just copy pasting the link is not working. That is why I'm asking here and not on the general "network for all" reddit forum. Is it related to needing to add the new file with hosts on "cdn.jsdelivr.net"? I saw through the documentation there is a mentioning of custom filters but points to a document which I don't understand, what I actually need to do to make it working. Hopefully now you understand why I'm asking here.

If this forum is not related to this kind of question, but is related how to add new code and features to the package then ok, I'm in the wrong forum then, I would appreciate if you can tell me the right thread for the above.